SHS-6029: Platform: "Reviewer" default role for viewing unpublished content

[cienvaras]

Summary

• Create and export "Reviewer" role
• Add update hook to assign permissions to the new "Reviewer" role to view any unpublished content (except for Private Pages)

Need Review By (Date)

02/19

Urgency

medium

Steps to Test

1. Visit the Roles page. Confirm that you can see the "Reviewer" role
2. Visit the permission list page for the "Reviewer" role. Confirm that the only permissions assigned are the "View any unpublished content" for all content types, except for "Private Page".
3. Edit a private page (for example Private page components) and unpublish it. Do the same for other node(s) (for example Testimonials).
4. Edit the "Howard" user, remove the "Contributor" role and assign the "Author" role (or any other role that can't see unpublished content).
5. Masquerade as Howard. Try to visit the pages that you previously unpublished. You shouldn't be able to do it.
6. Log out and then log in again using the tugboat user.
7. Edit the "Howard" user again and assign the "Reviewer" role
8. Repeat step 5. Now you should be able to see the non Private Page node(s) you unpublished. You should still be unable to see any unpublished private page(s).

Review Tasks

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Are PHP functions and variables in snake_case and not camelCase?
• Does Drupal code follow Drupal Coding Standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided?

Code security

• Is all user input properly sanitized when rendered?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209380999017953

[cienvaras]

@ahughes3 Ready for your review.

[ahughes3]

approved!

[joegl]

LGTM.