SHS-6081: Arrow in Vertical Linked Cards have indented to the next line

[mariannuar]

Summary

Fix arrow indentation in vertical linked cards

Need Review By (Date)

asap

Urgency

high

Steps to Test

1. Go to https://hs-colorful-gnc5hznyyk6qmrkwqkqqu9hx56kjfb38.tugboatqa.com/components/collections/collections-postcards/vertical-linked-cards or go to Components>Vertical Linked Cards and scroll down to Vertical Linked Cards with title and link in Colorful and Traditional
2. Make sure there's a short text in the link (if there isn't edit the text) to confirm the arrow is align with the text and not indented to the next line. Just a note that it will be indented to the next line if the text is too large and the container small
3. Now go to https://chemistry.stage.stanford.edu/outreach/chemical-education
4. Confirm the empty headings/titles are not being displayed in the markup. There was a condition that "fixed" the issue in this ticket, BUT, that wasn't fixed at all and it was causing this new issue. So please, take a look at it.

Review Tasks

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Are PHP functions and variables in snake_case and not camelCase?
• Does Drupal code follow Drupal Coding Standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided?

Code security

• Is all user input properly sanitized when rendered?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

[mariannuar]

@cienvaras This is ready for review!

[ahughes3]

@cienvaras this is one that fixes an issue we found during testing on Stage and is a blocker for this week's Prod release

[cienvaras]

@mariannuar LGTM!

@ahughes3 Ready for you

[ahughes3]

LGTM, I tested by comparing:

https://west-gnc5hznyyk6qmrkwqkqqu9hx56kjfb38.tugboatqa.com/students/explore-our-offerings-graduate-and-undergraduate-students

to

https://west-stage.stanford.edu/students/explore-our-offerings-graduate-and-undergraduate-students

since we have that environment on tugboat

[ahughes3]

@joegl we've approved this PR and would like to get it reviewed/merged and tested again and approved on stage before we move forward with the release

[joegl]

Happy to to get this in but this whole condition set is a bit confusing to me and I don't understand exactly why it's necessary / what it's doing.

[cienvaras]

Thanks @joegl! The condition was originally added (and then fixed in this PR) to ensure that we get a NULL in the template when the title is empty. The extra processing to strip the tags was causing a non null value in the template that was messing with the conditionals, so now we're only applying it when the title has content.

[joegl]

@cienvaras That makes sense, I'm just not understanding where the title loses content:

if (!empty($variables['title'])) {
    $title = is_array($variables['title']) ? $renderer->renderInIsolation($variables['title']) : $variables['title'];
    $variables['title'] = $title ? ['#markup' => trim(strip_tags($title))] : NULL;

The first line checks that the title is not empty. Second line renders it if it's an array. The only way it would be empty on line 3 then is if the renderInIsolation() method returns an empty value. Is that what's happening?