Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hsd8 000 fix acquia branch cleanup #1756

Closed
wants to merge 4 commits into from

Conversation

joegl
Copy link
Contributor

@joegl joegl commented Feb 21, 2025

Summary

[briefly summarize the changes here. TL;DR - what's this PR for?]

Need Review By (Date)

[When does this need to be reviewed by? '10/30', 'asap', etc.]

Urgency

['low', 'medium', 'high', etc.]

Steps to Test

  1. [First testing step]
  2. ...

Review Tasks

Backend / Functional Validation

Code

  • Are the naming conventions following our standards?
  • Are PHP functions and variables in snake_case and not camelCase?
  • Does Drupal code follow Drupal Coding Standards?
  • Does the code have sufficient inline comments?
  • Is there anything in this code that would be hidden or hard to discover through the UI?
  • Are there any code smells?
  • Are tests provided?

Code security

General

  • Is there anything included in this PR that is not related to the problem it is trying to solve?
  • Is the approach to the problem appropriate?

@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 18:35 Destroyed
@joegl joegl changed the base branch from develop to 11.8.1-release February 21, 2025 18:36
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 18:37 Destroyed
@ahughes3 ahughes3 temporarily deployed to Tugboat February 21, 2025 18:44 Destroyed
@joegl joegl closed this Feb 21, 2025
@joegl joegl deleted the HSD8-000--fix-acquia-branch-cleanup branch February 21, 2025 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants