fix(SHS-6113): duplicate node access records due to bug in su_humsci_profile_update_9723()

[dalin-]

Summary

Some update hooks to clean up duplicate node_access records that caused fatal exceptions. Those dupes were caused because not all sites had per-node Content Access enabled. So these updates enforce that for the Private Page node type.

Need Review By (Date)

ASAP. We need to prevent other people from experiencing fatal exceptions in the live environment.

Urgency

high

Steps to Test

1. Run drush updb and observe the output for su_humsci_profile_update_9725() and su_humsci_profile_update_9726()

On some sites you'll see output for 9725 to say that it enforced per-node Content Access. I haven't found a site that made any changes in 9726 (I suspect that the node_access_rebuild() called at the end of the previous update fixed those problems already).

Review Tasks

Backend / Functional Validation

Code

• Are the naming conventions following our standards?
• Are PHP functions and variables in snake_case and not camelCase?
• Does Drupal code follow Drupal Coding Standards?
• Does the code have sufficient inline comments?
• Is there anything in this code that would be hidden or hard to discover through the UI?
• Are there any code smells?
• Are tests provided?

Code security

• Is all user input properly sanitized when rendered?
• Any obvious security flaws or new areas for attack?

General

• Is there anything included in this PR that is not related to the problem it is trying to solve?
• Is the approach to the problem appropriate?

[joegl]

I tested this locally and it works. I just have a few formatting suggestions / requests. I am not going to hold this up from getting into the deployment on Wednesday for them.

It definitely appears the array_push in the previous update is the culprit and running array_unique solves the duplication.

I also double checked the custom module and didn't see anything concerning there: https://git.drupalcode.org/project/content_access_simple/-/blob/main/content_access_simple.module

[joegl]

LGTM, thanks @dalin-

[dalin-]

@joegl
In the latest push the Econ site was failing. Here's a commit to try and see why:
96aa9dc

[dalin-]

Here's a fix (I don't have permission to undelete this branch):
https://github.com/SU-HSDO/suhumsci/compare/11.8.1-release...SHS-6113_Temp-UnavailableError-issue-with-Private-Pages-and-Menus?expand=1