Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(SHS-6113): Exception on duplicate nodes being cleaned up #1770

Merged
merged 6 commits into from
Mar 4, 2025
Merged

fix(SHS-6113): Exception on duplicate nodes being cleaned up #1770

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
3504a03
fix(SHS-6113): duplicate node access records due to bug in su_humsci_…
dalin- Feb 28, 2025
ee55f7b
chore: syntax fix
dalin- Feb 28, 2025
b71ff58
chore: syntax fixes per PR review
dalin- Mar 3, 2025
96aa9dc
debug(SHS-6113): see why Econ site fails update
dalin- Mar 4, 2025
932cb6e
fix(SHS-6113): exception on some nodes being cleaned up.
dalin- Mar 4, 2025
b8b4997
Merge branch '11.8.1-release' into SHS-6113_Temp-UnavailableError-iss…
Mar 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion docroot/profiles/humsci/su_humsci_profile/su_humsci_profile.install
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1331,7 +1331,7 @@ function su_humsci_profile_update_9726(&$sandbox) {
$sandbox['ids'] = array_combine($ids, $ids);
$sandbox['total'] = count($sandbox['ids']);
}
$nids = array_slice($sandbox['ids'], 0, 50);
$nids = array_slice($sandbox['ids'], 0, 100);

/** @var \Drupal\node\NodeInterface $node */
foreach ($node_storage->loadMultiple($nids) as $node) {
Expand All @@ -1340,6 +1340,11 @@ function su_humsci_profile_update_9726(&$sandbox) {
$changed = FALSE;
if ($node_settings) {
foreach ($node_settings as $node_operation => &$node_permissions) {
if (!is_array($node_permissions)) {
// Oddly enough, we can get a "per_node" operation here. That might be
// a bug with the module.
continue;
}
$clean_permissions = array_unique($node_permissions);
if ($clean_permissions !== $node_permissions) {
$changed = TRUE;
Expand Down