Add block package #8
Open
+1,009
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidcassany
force-pushed
the
block_package
branch
4 times, most recently
from
6f1487c to
1dacb49
Compare
The block package adds an interface to list and detect partitions. In former Elemental Toolkit it was first implemented around wrapping lsblk command line and at a later point in time it was reimplemented around ghw library (we had to contribute there too). This current block package includes both implementations, one around ghw and another one around lsblk. I am not convinced it was a wise move using ghw, hence I'd go back to lsblk because is powerful and provides configurable JSON outputs which as easy to consume. I kept ghw around for the time being just in case we discover some limitation with the lsblk approach. Signed-off-by: David Cassany <dcassany@suse.com>
davidcassany
force-pushed
the
block_package
branch
from
1dacb49 to
9bc05b4
Compare
atanasdinov
reviewed
Mar 5, 2025
atanasdinov
approved these changes
Mar 5, 2025
Signed-off-by: David Cassany <dcassany@suse.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The block package adds an interface to list and detect partitions. In former Elemental Toolkit it was first implemented around wrapping lsblk command line and at a later point in time it was reimplemented around ghw library (we had to contribute there too).
This current block package includes both implementations, one around ghw and another one around lsblk. I am not convinced it was a wise move using ghw, hence I'd go back to lsblk because is powerful and provides configurable JSON outputs which are easy to consume. I kept ghw around for the time being just in case we discover some limitation with the lsblk approach.