Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Combined Delete & Insert break the local OT system #271

Closed
Tracked by #273
, #278
...
Luna-Klatzer opened this issue Jan 25, 2025 · 4 comments · Fixed by #273
Closed
Tracked by #273
, #278
...

Combined Delete & Insert break the local OT system #271

Luna-Klatzer opened this issue Jan 25, 2025 · 4 comments · Fixed by #273
Assignees
@Luna-Klatzer
Labels
bug Something isn't working critical Critical for the project or sprint
Milestone
Sprint 12

Comments

@Luna-Klatzer
Copy link
Contributor

Luna-Klatzer commented Jan 25, 2025 •
edited
Loading

On the deployed version v1.0.0-beta.2 selecting content and overwriting it causes the local OT system to break as a result of incorrect handling of the merged transformations (unified multiple-in-one transformations).
@Luna-Klatzer Luna-Klatzer added bug Something isn't working critical Critical for the project or sprint labels Jan 25, 2025
@Luna-Klatzer Luna-Klatzer added this to the Sprint 12 milestone Jan 25, 2025
@Luna-Klatzer Luna-Klatzer self-assigned this Jan 25, 2025
@Luna-Klatzer Luna-Klatzer moved this to Todo in SolarDoc Jan 25, 2025
@Luna-Klatzer
Copy link
Contributor Author

Cause narrowed down to a client-side problem of the local OT application algorithm. Potentially could be linked to other issues previously assumed issues as part of #226.

Luna-Klatzer added a commit that referenced this issue Jan 25, 2025
@Luna-Klatzer
fix (#271): Implemented proper local change lock to avoid race condit…
7b72fae 
…ions and split off multiple-in-one operations
@Luna-Klatzer Luna-Klatzer changed the title Uploading a file causes the default content to be inserted on top of the file Combined Delete & Insert break the local OT system Jan 25, 2025
@Luna-Klatzer
Copy link
Contributor Author

Cause detected and fixed with 7b72fae

@Luna-Klatzer Luna-Klatzer moved this from Todo to In Progress in SolarDoc Jan 25, 2025
@Luna-Klatzer Luna-Klatzer moved this from In Progress to Verify in SolarDoc Jan 25, 2025
@Luna-Klatzer
Copy link
Contributor Author

Primary fix here:

7b72fae#diff-e01beaae73d5fbe93d9eed36ae3f025a162bfe93eb2e523f356a95414a6f106fR18-R24

@Luna-Klatzer Luna-Klatzer mentioned this issue Jan 25, 2025
Merged
6 tasks
@Luna-Klatzer Luna-Klatzer linked a pull request Jan 25, 2025 that will close this issue
Fixed bug causing combined Delete & Insert to break the local OT system #273
Merged
6 tasks
@Luna-Klatzer
Copy link
Contributor Author

Fixed by #273 and will be shipped with v1.0.0-beta.3

@github-project-automation github-project-automation bot moved this from Verify to Done in SolarDoc Jan 25, 2025
@Luna-Klatzer Luna-Klatzer mentioned this issue Jan 27, 2025
Merged
19 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Luna-Klatzer Luna-Klatzer

Labels
bug Something isn't working critical Critical for the project or sprint
Projects
SolarDoc
Status: Done
Milestone
Sprint 12
1 participant
@Luna-Klatzer