Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed bug causing combined Delete & Insert to break the local OT system #273

Conversation

Luna-Klatzer
Copy link
Contributor

What type of change does this PR perform?

  • Maintenance (Non-breaking change that updates dependencies)
  • Development changes (Changes that do not add new features or fix bugs, but update the project in other ways)
  • Bug fix (Non-breaking change which fixes an issue)
  • Feature (Non-breaking change which adds functionality)
  • Breaking change (Major bug fix or feature that would cause existing functionality not to work as expected.)

Summary

Fixed bug causing combined Delete & Insert to break the local OT system.

Closes #271

List of Changes

  • Implemented new AsyncLock which allows the async locking of multiple processes requiring sequential critical sections.
  • Split unified multiple-in-one operations and added sequential locked execution.
  • Fixed bug of unnecessary phantom requests for the owner property of local files.
  • Removed unnecessary success callback in SDSClient.sendOTrans() which does nothing.
  • Added local debug logging of the file content as a way to test OT update cycles.

Does this PR create new warnings?

None.

Linked issues or PRs

@Luna-Klatzer Luna-Klatzer added bug Something isn't working fix Fixes an issue or bug labels Jan 25, 2025
@Luna-Klatzer Luna-Klatzer added this to the Sprint 12 milestone Jan 25, 2025
@Luna-Klatzer Luna-Klatzer requested a review from a team January 25, 2025 21:09
@Luna-Klatzer Luna-Klatzer self-assigned this Jan 25, 2025
@Luna-Klatzer Luna-Klatzer linked an issue Jan 25, 2025 that may be closed by this pull request
@Luna-Klatzer Luna-Klatzer merged commit f1fb293 into dev-sprint-12 Jan 25, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working fix Fixes an issue or bug
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Combined Delete & Insert break the local OT system
1 participant