Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Overloaded functions where ignored by the analyzer. #151

Merged
merged 2 commits into from
Jun 18, 2024

Conversation

Masara
Copy link
Contributor

@Masara Masara commented Jun 14, 2024

Closes #144

Summary of Changes

Fixed a bug where overloaded functions where ignored by the analyzer.

@Masara Masara requested a review from a team as a code owner June 14, 2024 22:36
@Masara Masara linked an issue Jun 14, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 14, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 1 0 0 0.45s
✅ PYTHON mypy 1 0 5.25s
✅ PYTHON ruff 1 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.02s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.55%. Comparing base (ece49aa) to head (c52f6d3).
Report is 24 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #151   +/-   ##
=======================================
  Coverage   99.55%   99.55%           
=======================================
  Files          25       25           
  Lines        2477     2479    +2     
=======================================
+ Hits         2466     2468    +2     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lars-reimann lars-reimann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, thank you.

@lars-reimann lars-reimann merged commit 3f87c26 into main Jun 18, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 144-overloaded-methods-are-skipped branch June 18, 2024 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Overloaded methods are skipped
3 participants