Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Combine multiple examples to one #152

Merged
merged 4 commits into from
Jun 20, 2024

Conversation

Masara
Copy link
Contributor

@Masara Masara commented Jun 15, 2024

Closes #139

Summary of Changes

Multiple example docstrings are now combined to one big example docstrings will now each have an example block in Safe-DS docstrings. Previously only the first docstring was saved and others where ignored.

@Masara Masara requested a review from a team as a code owner June 15, 2024 11:49
@Masara Masara linked an issue Jun 15, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jun 15, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 0.9s
✅ PYTHON mypy 3 0 5.48s
✅ PYTHON ruff 3 0 0 0.04s
✅ REPOSITORY git_diff yes no 0.03s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jun 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.56%. Comparing base (48ad9da) to head (545d806).
Report is 19 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #152   +/-   ##
=======================================
  Coverage   99.56%   99.56%           
=======================================
  Files          25       25           
  Lines        2516     2521    +5     
=======================================
+ Hits         2505     2510    +5     
  Misses         11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lars-reimann
Copy link
Member

@Masara Needs conflict resolution.

# Conflicts:
#	tests/data/docstring_parser_package/numpydoc.py
#	tests/safeds_stubgen/stubs_generator/__snapshots__/test_generate_stubs/test_stub_docstring_creation[numpydoc-NUMPYDOC].sdsstub
@lars-reimann lars-reimann merged commit fa09129 into main Jun 20, 2024
8 checks passed
@lars-reimann lars-reimann deleted the 139-only-one-example-created branch June 20, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only one example created
2 participants