Merge pull request #98 from Sage-Bionetworks/etl-589

[ETL-589] Fix parameter type in delete_objects call
Sage-Bionetworks · Dec 19, 2023 · abf9097 · abf9097
2 parents b19936b + 96c1853
commit abf9097
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/glue/jobs/json_to_parquet.py b/src/glue/jobs/json_to_parquet.py
@@ -361,7 +361,7 @@ def archive_existing_datasets(
     if delete_upon_completion and archived_objects:
         deleted_response = s3_client.delete_objects(
                 Bucket=bucket,
-                Delete={"Objects": {"Key": obj["Key"] for obj in archived_objects}}
+                Delete=[obj["Key"] for obj in archived_objects]
         )
     return archived_objects
 

diff --git a/tests/test_json_to_parquet.py b/tests/test_json_to_parquet.py
@@ -926,7 +926,7 @@ def test_archive_existing_datasets_delete(
             )
             mock_client.delete_objects.assert_called_once_with(
                     Bucket=artifact_bucket,
-                    Delete={"Objects": {"Key": obj["Key"] for obj in archived_objects}}
+                    Delete=[obj["Key"] for obj in archived_objects]
             )
 
     def test_drop_deleted_healthkit_data(