-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SWC-6915 #1562
base: main
Are you sure you want to change the base?
SWC-6915 #1562
Conversation
@nickgros still working on making sure the mobile flow is handled correctly. Would love to get your eyes on this early to make sure that I haven't lost any functionality in the refactor from base |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you could simplify the layout quite a bit, so I tried to communicate one potential path forward in these comments--it's a lot, so please reach out if you have questions!
packages/synapse-react-client/src/components/widgets/RangeSlider/RangeSlider.tsx
Outdated
Show resolved
Hide resolved
Oh and it seems like the functionality is fine just from trying it in Storybook, but I think existing tests should verify this too! |
@nickgros really appreciate this in depth review! It's making sense after I read through it a couple times. I'll ping you for rereview once I've implemented. |
@nickgros I'm a little stuck on how to make an update to the storybook entry. Here's what I've figured out so far: Storybook entry: Line 89 in df26c7f
Runs RangeFaceFilterUI: https://github.com/Sage-Bionetworks/synapse-web-monorepo/blob/main/packages/synapse-react-client/src/components/widgets/query-filter/RangeFacetFilterUI.tsx#L48 The Storybook entry doesn’t really seem appropriate for the DateRangePicker?
I’ve been playing around with these values via the storybook UI and they don’t update the values in the DateRangePicker. I've updated the values in my local instance but it's taking forever to boot up locally and I need to log off for the day. @nickgros can you point me towards where the default storybook dates are coming from? |
@lakikowolfe I think you're in the right place. If you change the values in that story to dates (e.g. |
Code changes look good, looks like tests need to be updated |
Update date range picker design
Update enum range slider design
https://sagebionetworks.jira.com/browse/SWC-6915