Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SWC-6915 #1562

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

SWC-6915 #1562

wants to merge 13 commits into from

Conversation

lakikowolfe
Copy link
Contributor

Update date range picker design

  • Control flow from desktop to mobile
  • Style button to match designs in figma
  • Update to use MUI components

Update enum range slider design

  • Style apply button to match figma designs

https://sagebionetworks.jira.com/browse/SWC-6915

@lakikowolfe lakikowolfe marked this pull request as ready for review February 11, 2025 19:56
@lakikowolfe lakikowolfe requested a review from nickgros February 11, 2025 19:57
@lakikowolfe
Copy link
Contributor Author

@nickgros still working on making sure the mobile flow is handled correctly. Would love to get your eyes on this early to make sure that I haven't lost any functionality in the refactor from base input to MUI DatePicker

Copy link
Collaborator

@nickgros nickgros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you could simplify the layout quite a bit, so I tried to communicate one potential path forward in these comments--it's a lot, so please reach out if you have questions!

@nickgros
Copy link
Collaborator

Oh and it seems like the functionality is fine just from trying it in Storybook, but I think existing tests should verify this too!

@lakikowolfe
Copy link
Contributor Author

@nickgros really appreciate this in depth review! It's making sense after I read through it a couple times. I'll ping you for rereview once I've implemented.

@lakikowolfe
Copy link
Contributor Author

lakikowolfe commented Feb 13, 2025

@nickgros I'm a little stuck on how to make an update to the storybook entry. Here's what I've figured out so far:

Storybook entry:

Runs RangeFaceFilterUI: https://github.com/Sage-Bionetworks/synapse-web-monorepo/blob/main/packages/synapse-react-client/src/components/widgets/query-filter/RangeFacetFilterUI.tsx#L48

The Storybook entry doesn’t really seem appropriate for the DateRangePicker?

export const SelectedDate: Story = {
  args: {
    label: 'foo',
    columnType: 'DATE',
    facetResult: {
      columnMin: '0',
      columnMax: '100',
      selectedMin: '5',
      selectedMax: '95',
    },
  },
}

I’ve been playing around with these values via the storybook UI and they don’t update the values in the DateRangePicker.

I've updated the values in my local instance but it's taking forever to boot up locally and I need to log off for the day. @nickgros can you point me towards where the default storybook dates are coming from?

@nickgros
Copy link
Collaborator

@lakikowolfe I think you're in the right place. If you change the values in that story to dates (e.g. '2025-02-13'), then I think it will work. You might not see the change in storybook without a full refresh to the page

@nickgros
Copy link
Collaborator

Code changes look good, looks like tests need to be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants