Fix redis connection pooling for nonce management #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LyleDavis
changed the title
noodl
previously approved these changes
Jan 20, 2025
LauraCollins-Sage
previously approved these changes
Jan 20, 2025
LyleDavis
dismissed stale reviews from LauraCollins-Sage and noodl
via
0060007
LauraCollins-Sage
previously approved these changes
Jan 20, 2025
noodl
previously approved these changes
Jan 20, 2025
LyleDavis
dismissed stale reviews from noodl and LauraCollins-Sage
via
12a3bf7
noodl
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This previously wasn’t pooling redis connections properly.
I’ve removed redlock as we weren’t using its distributed functionality, replacing it with just standard key in redis set with NX to reuse the same connection pool and use a single operation to avoid thread/process conflicts.