chore: Port Spring 2.7 -> 3.2, JDK17 #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rnd4you
requested review from
tiokim,
MoonkiHong,
o-kopysov and
tdrozdovsky
as code owners
o-kopysov
changed the title
o-kopysov
requested changes
Jan 3, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #386 +/- ##
=========================================
Coverage 90.90% 90.90%
Complexity 486 486
=========================================
Files 47 47
Lines 1737 1737
Branches 209 209
=========================================
Hits 1579 1579
Misses 94 94
Partials 64 64 ☔ View full report in Codecov by Sentry. |
o-kopysov
reviewed
Jan 5, 2024
README.md
Outdated
| @@ -11,39 +11,39 @@ | |||
| [](https://sourcespy.com/github/samsunglpvs/) | |||
|
|
|||
| ## Introduction | |||
| Open-source code [refers](https://en.wikipedia.org/wiki/Open-source_software) to software that is freely available for use, study, modification, and distribution, subject to meeting the conditions of the corresponding license. Failure to comply with the license conditions can lead to legal disputes, financial liabilities, the requirement to disclose intellectual property, and reputational damage. | |||
| Open-source code [refers](https://en.wikipedia.org/wiki/Open-source_software) (that is a software that is freely available for use, study, modification, and distribution) must meet the conditions of the respective license(s) of all of its dependencies. Miscompliance may lead to legal disputes, financial liabilities, obligation to disclose proprietary intellectual property, as well as reputational damage. | |||
There was a problem hiding this comment.
refers is a redundant word.
pom.xml
Outdated
| @@ -7,7 +7,7 @@ | |||
| <groupId>com.lpvs</groupId> | |||
| <artifactId>lpvs</artifactId> | |||
| <name>LPVS</name> | |||
| <version>1.3.0</version> | |||
| <version>1.3.1</version> | |||
| @@ -10,7 +10,7 @@ | |||
| import lombok.Getter; | |||
| import lombok.Setter; | |||
|
|
|||
| import javax.persistence.*; | |||
| import jakarta.persistence.*; // Spring 3.2 | |||
There was a problem hiding this comment.
Please remove unnecessary comment
|
Please resolve conflicts with |
rnd4you
force-pushed
the
rnd4you
branch
3 times, most recently
from
53bf11d to
59ab849
Compare
…hange environmemt vars
Signed-off-by: rnd4you <rnd4u.org@gmail.com>
Signed-off-by: rnd4you <rnd4u.org@gmail.com>
Samsung#385) fix: Change "npm install" to "npm ci" to install fixed version packages for docker image Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
Samsung#384) * fix: Add throw Exception in case of error for LPVSWebhookUtil class Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update catch code to process IllegalArgumentException Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: Mykola Rudyk <m.rudyk@samsung.com>
* feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * feat: Add API for single pull request scan Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * docs: Add new endpoint description in YAML file Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Cover new endpoint by unit tests Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * test: Update unit tests for LPVSPullRequestAction Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update endpoint based on the code review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Fix build after incorrect rebase Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> * fix: Update code based on the review comments Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com> --------- Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
Signed-off-by: rnd4you <rnd4u.org@gmail.com>
Signed-off-by: rnd4you <rnd4u.org@gmail.com>
Signed-off-by: rnd4you <rnd4u.org@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
This is for #351
Description
Spring 2.7 has been replaced with 3.2.
Fixes #351
Type of change
Testing
All previous tests that used to work with Spring 2.7 are operating well with Spring 3.2 as well.
Checklist: