Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Test java-kotlin for codeql analysis #408

Merged
merged 1 commit into from
Feb 2, 2024

Conversation

tdrozdovsky
Copy link
Collaborator

Pull Request

Description

While only test

Type of change

  • CI system update

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ef1a6db) 90.90% compared to head (c8e6778) 90.90%.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #408   +/-   ##
=========================================
  Coverage     90.90%   90.90%           
  Complexity      486      486           
=========================================
  Files            47       47           
  Lines          1737     1737           
  Branches        209      209           
=========================================
  Hits           1579     1579           
  Misses           94       94           
  Partials         64       64           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@o-kopysov o-kopysov reopened this Feb 1, 2024
@o-kopysov o-kopysov added this to the v1.4.1 milestone Feb 1, 2024
Copy link
Collaborator

@o-kopysov o-kopysov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@o-kopysov o-kopysov added the github_actions Pull requests that update GitHub Actions code label Feb 1, 2024
Signed-off-by: Taras Drozdovskyi <t.drozdovsky@samsung.com>
Copy link
Collaborator

@m-rudyk m-rudyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@o-kopysov o-kopysov merged commit 4b9604d into Samsung:main Feb 2, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants