Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix the issue with duplicated records in pull_requests table and runtime error (missing bean) #446

Merged
merged 2 commits into from
Feb 29, 2024

Conversation

o-kopysov
Copy link
Collaborator

@o-kopysov o-kopysov commented Feb 28, 2024

Pull Request

Description

I found that in case the scan fails, LPVS saves pull request information into the table pull_requests for each failed attempt.
This is incorrect behavior. Only one record should be saved for every webhook request.
Also fixed runtime issue with missing ClientRegistrationRepository bean.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Code cleanup/refactoring
  • Documentation update
  • This change requires a documentation update
  • CI system update
  • Test Coverage update

Testing

Test Configuration:

  • Java: v17
  • LPVS Release: v1.4.1

Checklist:

  • My code follows the style guidelines of this project
  • My code meets the required code coverage for lines (90% and above)
  • My code meets the required code coverage for branches (80% and above)
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov added the fix label Feb 28, 2024
@o-kopysov o-kopysov added this to the v1.4.2 milestone Feb 28, 2024
@o-kopysov o-kopysov self-assigned this Feb 28, 2024
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 91.30435% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 90.65%. Comparing base (d0e8ba2) to head (95d19a7).

Files Patch % Lines
src/main/java/com/lpvs/config/SecurityConfig.java 0.00% 1 Missing ⚠️
...c/main/java/com/lpvs/service/LPVSQueueService.java 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #446      +/-   ##
============================================
- Coverage     90.76%   90.65%   -0.11%     
+ Complexity      489      488       -1     
============================================
  Files            47       47              
  Lines          1732     1744      +12     
  Branches        207      208       +1     
============================================
+ Hits           1572     1581       +9     
- Misses           97       99       +2     
- Partials         63       64       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Oleg Kopysov <o.kopysov@samsung.com>
@o-kopysov o-kopysov changed the title fix: Fix the issue with duplicated records in pull_requests table fix: Fix the issue with duplicated records in pull_requests table and runtime error (missing bean) Feb 29, 2024
Copy link
Collaborator

@o-konoval o-konoval left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixing issues. Approved.

@o-kopysov o-kopysov merged commit d04c45a into main Feb 29, 2024
10 checks passed
@o-kopysov o-kopysov deleted the fix-attempts branch February 29, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants