Parseargs #25
Merged
Parseargs #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrsamsung
force-pushed
the
parseargs
branch
2 times, most recently
from
7245e88 to
6653af4
Compare
.. and move arg checking involving *program* exit out from parse_spec and into __main__ (the CLI)
Move the stage2.schema.json from the root of the project into the src directory, include it explicitly in MANIFEST.in to have it included in the resulting nvme-spex package. Add jsonschema as dependency. Add cmdline flag `--validate-json`. When running spex with the new flag it will validate that the resulting json aligns with the schema.
Use modern packaging with pyproject.toml and build. It will still use setuptools but will run through the generic build interface.
jwdevantier
approved these changes
Apr 18, 2024
flake.nix
Outdated
| spex = (buildPythonPackage rec { | ||
| pname = "spex"; | ||
| version = revision; | ||
| format = "setuptools"; | ||
| src = ./.; | ||
| doCheck = false; | ||
| propagatedBuildInputs = (spexDeps pkgs); | ||
| propagatedBuildInputs = (spexDeps pkgs) ; |
There was a problem hiding this comment.
remove whitespace if possible
jwdevantier
approved these changes
Apr 18, 2024
src/spexsrv/static/hello.txt
Outdated
There was a problem hiding this comment.
this should not be there hehe :D
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.