Add functionality to run nvme-spex with docker #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
mbrsamsung
commented
Sep 23, 2024
mbrsamsung
commented
- Add docker entrypoint script
- Add documentation describing it
Add new `cmd.sh` script with case matches for subcommands. This enables the docker contrainer to both serv a webserver and run nvme-spex directly on files. Signed-off-by: Morten B. Rasmussen <m.rasmussen@samsung.com>
mbrsamsung
force-pushed
the
mbr/dockerize
branch
from
b85aaba to
a67a7e0
Compare
safl
reviewed
Sep 24, 2024
docs/source/index.rst
Outdated
| docker. For setup of docker on windows we refer to guides from `Docker Desktop | ||
|
|
||
| For direct usage of nvme-spex it is possible to run it from docker. For setup of | ||
| docker on windows we refer to guides from `Docker Desktop | ||
| <https://docs.docker.com/desktop/install/windows-install/>`_ or `Podman |
There was a problem hiding this comment.
I think the reference to Podman should be replace with a reference to Podman Desktop: https://podman-desktop.io/downloads On this topic, why propose Docker Desktop? I don't see any value of Docker Desktop over Podman Desktop, more choice usually turns into confusion.
Strike that... let's drop Podman Desktop... otherwise the docker run ... examples becomes confusing as these would then need to be podman ...
Adds instructions to the sphinx documentation, that describes how it is possible to use nvme-spex directly through docker. Without starting the webserver. Signed-off-by: Morten B. Rasmussen <m.rasmussen@samsung.com>
mbrsamsung
force-pushed
the
mbr/dockerize
branch
from
a67a7e0 to
ec33240
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.