New reporting view for web & add spex version attribute to stage 1 and 2 docs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbrsamsung
force-pushed
the
mbr/feat-ui
branch
3 times, most recently
from
f9c0ee0 to
a854a6d
Compare
Builds upon the existing report view but now includes the html part of the figures that have linting violations. Further there was an issue with showing a limited amount of linting errors. The functionality that should show a list of linting errors, was iterating through the list of parsed figures and appending its linting errors. This means that tables that are not being parsed by error or otherwise would not be shown. Now It iterates through the errors and show that. Signed-off-by: Morten B. Rasmussen <m.rasmussen@samsung.com>
Signed-off-by: Morten B. Rasmussen <m.rasmussen@samsung.com>
mbrsamsung
force-pushed
the
mbr/feat-ui
branch
from
a854a6d to
1664c76
Compare
mbrsamsung
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds upon the existing report view but now includes the html part of the figures that have linting violations.
Further there was an issue with showing a limited amount of linting errors. The functionality that should show a list of linting errors, was iterating through the list of parsed figures and appending its linting errors. This means that tables that are not being parsed by error or otherwise would not be shown. Now It iterates through the errors and show that.