-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Convert bookmarks upgrade scenarios to new format #16856
Convert bookmarks upgrade scenarios to new format #16856
Conversation
trigger: test-robottelo |
trigger: test-robottelo |
1 similar comment
trigger: test-robottelo |
PRT Result
|
As part of the upgrade scenarios conversion effort, this PR changes the bookmarks upgrade scenario tests to use the shared resource framework and converts the pre-upgrade scenarios to pytest fixtures. It also adds a new shared Satellite fixture for search component tests.
1771cbf
to
6ec3c3e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ACK, nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks neat and great!
The only thing - would you mind to update the CODEOWNERS file with the new additions? We use it for the team-based review requests / heads up. Thank you!
@vsedmik Just updated with the change to the CODEOWNERS file. |
This pull request has not been updated in the past 45 days. |
This pull request is now being closed after stale warnings. |
* Convert bookmarks upgrade scenarios to new format As part of the upgrade scenarios conversion effort, this PR changes the bookmarks upgrade scenario tests to use the shared resource framework and converts the pre-upgrade scenarios to pytest fixtures. It also adds a new shared Satellite fixture for search component tests. * Address linting failure * Add new test module to CODEOWNERS file (cherry picked from commit 3868daa)
* Convert bookmarks upgrade scenarios to new format As part of the upgrade scenarios conversion effort, this PR changes the bookmarks upgrade scenario tests to use the shared resource framework and converts the pre-upgrade scenarios to pytest fixtures. It also adds a new shared Satellite fixture for search component tests. * Address linting failure * Add new test module to CODEOWNERS file (cherry picked from commit 3868daa)
As part of the upgrade scenarios conversion effort, this PR changes the bookmarks upgrade scenario tests to use the shared resource framework and converts the pre-upgrade scenarios to pytest fixtures. It also adds a new shared Satellite fixture for search component tests.