Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix IPv6 Infoblox tests #17340

Merged
merged 1 commit into from
Feb 26, 2025
Merged

Fix IPv6 Infoblox tests #17340

merged 1 commit into from
Feb 26, 2025
+14 −14

Conversation

shubhamsg199
Copy link
Contributor

@shubhamsg199 shubhamsg199 commented Jan 15, 2025 •
edited
Loading

Fixing IPv6 Infoblox tests

  • Removing isc_dhcp as we don't really test it with infoblox integration and we don't document that as well
  • The domain created is already present in the IPv6 satellite hence adding condition to check first and create it if not present

Satellite Jenkins MR: 1618

@shubhamsg199 shubhamsg199 added No-CherryPick PR doesnt need CherryPick to previous branches Stream Introduced in or relating directly to Satellite Stream/Master labels Jan 15, 2025
@shubhamsg199 shubhamsg199 self-assigned this Jan 15, 2025
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner January 15, 2025 18:08
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py

ekohl
ekohl requested changes Jan 15, 2025
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing isc_dhcp as we don't really test it with infoblox integration and we don't document that as well

👍 for that. It deserves its own test

Fixing IPv6 Infoblox tests

How can this fix IPv6 tests if the verification is still only verifying it creates an A record?

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 9890
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ================= 3 passed, 512 warnings in 3677.92s (1:01:17) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Jan 15, 2025
amolpati30
amolpati30 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Contributor

@amolpati30 amolpati30 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please update as per Ekohl's suggestion. Ack

@shweta83
Copy link
Contributor

shweta83 commented Feb 5, 2025

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10065
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ============ 1 failed, 2 passed, 512 warnings in 3602.83s (1:00:02) ============

@Satellite-QE Satellite-QE added PRT-Failed Indicates that latest PRT run is failed for the PR and removed PRT-Passed Indicates that latest PRT run is passed for the PR labels Feb 5, 2025
@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch 2 times, most recently from 7e303a6 to 097d0f3 Compare February 24, 2025 16:52
ekohl
ekohl reviewed Feb 24, 2025
View reviewed changes
@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch from 097d0f3 to fb267b1 Compare February 24, 2025 17:06
ekohl
ekohl approved these changes Feb 24, 2025
View reviewed changes
Copy link
Contributor

@ekohl ekohl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! That helps a lot.

@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch from fb267b1 to 96aacbb Compare February 24, 2025 17:16
@shubhamsg199 shubhamsg199 requested a review from a team as a code owner February 24, 2025 17:16
@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch from 96aacbb to f71341d Compare February 25, 2025 08:16
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10303
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ============ 1 failed, 2 passed, 559 warnings in 4101.82s (1:08:21) ============

@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch 2 times, most recently from 8e8a9a5 to 2a3e526 Compare February 25, 2025 10:39
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10307
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ============ 1 failed, 2 passed, 543 warnings in 3894.77s (1:04:54) ============

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10316
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ============ 1 failed, 2 passed, 508 warnings in 3523.19s (0:58:43) ============

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10322
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ============ 1 failed, 2 passed, 542 warnings in 3734.92s (1:02:14) ============

@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch from 2a3e526 to 397e06d Compare February 26, 2025 09:01
@shubhamsg199
Fix ipv6 Infoblox test
62270ab 
Signed-off-by: Shubham Ganar <sganar@redhat.com>
@shubhamsg199 shubhamsg199 force-pushed the Fix_ipv6_Infoblox_test branch from 397e06d to 62270ab Compare February 26, 2025 09:02
@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10325
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ================= 3 failed, 509 warnings in 3872.27s (1:04:32) =================

@shubhamsg199
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/destructive/test_infoblox.py
nailgun: 1282
network_type: ipv6

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10326
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/destructive/test_infoblox.py --external-logging
Test Result : ================= 3 passed, 511 warnings in 4594.97s (1:16:34) =================

@Satellite-QE Satellite-QE added PRT-Passed Indicates that latest PRT run is passed for the PR and removed PRT-Failed Indicates that latest PRT run is failed for the PR labels Feb 26, 2025
@shubhamsg199 shubhamsg199 mentioned this pull request Feb 26, 2025
Merged
@Gauravtalreja1 Gauravtalreja1 added CherryPick PR needs CherryPick to previous branches 6.17.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing and removed No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 26, 2025
@Gauravtalreja1 Gauravtalreja1 merged commit dfbee71 into SatelliteQE:master Feb 26, 2025
16 checks passed
github-actions bot pushed a commit that referenced this pull request Feb 26, 2025
@shubhamsg199 @web-flow
Fix IPv6 Infoblox tests (#17340)
5a9f790 
Fix ipv6 Infoblox test

Signed-off-by: Shubham Ganar <sganar@redhat.com>
(cherry picked from commit dfbee71)
This was referenced Feb 26, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ekohl ekohl ekohl approved these changes

@Gauravtalreja1 Gauravtalreja1 Gauravtalreja1 approved these changes

@amolpati30 amolpati30 amolpati30 approved these changes

Assignees

@shubhamsg199 shubhamsg199

Labels
6.17.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR Stream Introduced in or relating directly to Satellite Stream/Master
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@shubhamsg199 @Satellite-QE @shweta83 @ekohl @Gauravtalreja1 @amolpati30