Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix katello host tools pkg installation issue #17703

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

vijaysawant
Copy link
Contributor

Problem Statement

Test setup were failing while katello host tools pkg installation on RHEL-7 content_host
Error Details - failed on setup with "robottelo.hosts.ContentHostError: Failed to install katello-host-tools"
After investigation found root cause, katello host tools installation failing due to dependant pkg crontabs, and that dependant pkg is present in rhel-7-server-rpms.

Affected test cases:

tests/foreman/cli/test_contentaccess.py::test_negative_unregister_and_pull_content[rhel7_contenthost_module0] 
tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] 
tests/foreman/cli/test_contentaccess.py::test_positive_erratum_installable[rhel7_contenthost_module0] 

Solution

Enable RHEL-7 Server repository and add into the related CV

Related Issues

N/A

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentaccess.py -k 'test_negative_unregister_and_pull_content or test_positive_list_installable_updates or test_positive_erratum_installable'

@vijaysawant vijaysawant added CherryPick PR needs CherryPick to previous branches AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing Stream Introduced in or relating directly to Satellite Stream/Master 6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z labels Feb 27, 2025
@vijaysawant vijaysawant requested a review from a team as a code owner February 27, 2025 03:49
@vijaysawant vijaysawant added the TestFailure Issues and PRs related to a test failing in automation label Feb 27, 2025
@vijaysawant
Copy link
Contributor Author

vijaysawant commented Feb 27, 2025

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentaccess.py -k 'test_negative_unregister_and_pull_content or test_positive_list_installable_updates or test_positive_erratum_installable'

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 10333
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_contentaccess.py -k test_negative_unregister_and_pull_content or test_positive_list_installable_updates or test_positive_erratum_installable --external-logging
Test Result : ===== 2 failed, 1 passed, 1 deselected, 37 warnings in 1936.15s (0:32:16) ======

@Satellite-QE Satellite-QE added the PRT-Failed Indicates that latest PRT run is failed for the PR label Feb 27, 2025
@vijaysawant
Copy link
Contributor Author

Local test execution result:

tests/foreman/cli/test_contentaccess.py::test_negative_unregister_and_pull_content[rhel7_contenthost_module0] 
================= 1 passed, 3 deselected in 606.50s (0:10:06) ==================
PASSED
Process finished with exit code 0


tests/foreman/cli/test_contentaccess.py::test_positive_list_installable_updates[rhel7_contenthost_module0] 
================= 1 passed, 3 deselected in 777.50s (0:12:57) ==================
PASSED
Process finished with exit code 0


tests/foreman/cli/test_contentaccess.py::test_positive_erratum_installable[rhel7_contenthost_module0] 
================= 1 passed, 3 deselected in 610.70s (0:10:10) ==================
PASSED
Process finished with exit code 0

@vijaysawant
Copy link
Contributor Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_contentaccess.py -k 'test_negative_unregister_and_pull_content or test_positive_list_installable_updates or test_positive_erratum_installable'

Copy link
Contributor

@synkd synkd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While these changes look appropriate for achieving the stated goal, have you considered either updating this module to use a more recent RHEL version than RHEL 7 or, better yet, parametrizing it for all supported RHEL versions? RHEL 7 is now out of maintenance support and is in its extended life cycle support phase.

I won't consider this a blocking question, and I don't want to pick on you specifically, @vijaysawant, since I know this pattern is common throughout the Robottelo codebase. However, I think it would be good to take opportunities move away from it when we encounter them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.16.z Introduced in or relating directly to Satellite 6.16 6.17.z AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing CherryPick PR needs CherryPick to previous branches PRT-Failed Indicates that latest PRT run is failed for the PR Stream Introduced in or relating directly to Satellite Stream/Master TestFailure Issues and PRs related to a test failing in automation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants