Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.17.z] Multiple PhoenixSubs test fixes #17706

Conversation

Satellite-QE
Copy link
Collaborator

Cherrypick of PR: #17705

Problem Statement

There were still some outdated tests in our test framework which were failing for a while

Solution

This PR fixes some of those tests

PRT test Cases example

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py::TestDockerActivationKey::test_positive_add_docker_repo_ccv tests/foreman/cli/test_docker.py::TestDockerActivationKey::test_positive_remove_docker_repo_ccv tests/foreman/cli/test_activationkey.py::test_positive_update_cv  tests/foreman/api/test_reporttemplates.py::test_positive_installed_products

Tests passed locally

collected 6 items
tests/foreman/cli/test_docker.py ..                                          [ 33%]
tests/foreman/cli/test_activationkey.py .                                [ 50%]
tests/foreman/api/test_reporttemplates.py ...                          [100%]
...
6 passed

* Multiple PhoenixSubs test fixes

* Alter asserts

(cherry picked from commit adc2a10)
@Satellite-QE Satellite-QE requested a review from a team as a code owner February 27, 2025 18:06
@Satellite-QE Satellite-QE added 6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA No-CherryPick PR doesnt need CherryPick to previous branches labels Feb 27, 2025
@Satellite-QE
Copy link
Collaborator Author

trigger: test-robottelo
pytest: tests/foreman/cli/test_docker.py::TestDockerActivationKey::test_positive_add_docker_repo_ccv tests/foreman/cli/test_docker.py::TestDockerActivationKey::test_positive_remove_docker_repo_ccv tests/foreman/cli/test_activationkey.py::test_positive_update_cv  tests/foreman/api/test_reporttemplates.py::test_positive_installed_products

@Satellite-QE Satellite-QE added the AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing label Feb 27, 2025
@Satellite-QE
Copy link
Collaborator Author

PRT Result

Build Number: 10348
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_docker.py::TestDockerActivationKey::test_positive_add_docker_repo_ccv tests/foreman/cli/test_docker.py::TestDockerActivationKey::test_positive_remove_docker_repo_ccv tests/foreman/cli/test_activationkey.py::test_positive_update_cv  tests/foreman/api/test_reporttemplates.py::test_positive_installed_products --external-logging
Test Result : ================= 6 passed, 157 warnings in 1028.06s (0:17:08) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Feb 27, 2025
@Satellite-QE Satellite-QE merged commit c8c0bd6 into 6.17.z Feb 27, 2025
18 of 19 checks passed
@Satellite-QE Satellite-QE deleted the cherry-pick-6.17.z-adc2a10d30575d82778e79579ef504359948c119 branch February 27, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.17.z Auto_Cherry_Picked Automatically cherrypicked PR using GHA AutoMerge_Cherry_Picked The cherrypicked PRs of master PR would be automerged if all checks passing No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants