-
Notifications
You must be signed in to change notification settings - Fork 136
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
snfoundry: Update dependencies #449
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the change to the action. These updates improve the workflow by using GitHub Actions for installing tools (setup-scarb
and setup-snfoundry
) instead of custom scripts.
I've also tested with devnet version 0.2.4/0.2.3, scarb 2.10.1, and snfoundry 0.38.0, in preparation for the mainnet release 0.14.0 on March 17th. Currently, devnet is not ready, as it is still in the following PR:
However, it is working fine on Sepolia:
So, the proposed change is the best option right now. The README should also be updated to reflect the new versions.
Once the ODBuild reviews are finished, it can be merged.
Task name here
Fixes #relevant-issue-here
Types of change
Comments (optional)