Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

snfoundry: Update dependencies #449

Open
wants to merge 11 commits into
base: main
Choose a base branch
from
Open

snfoundry: Update dependencies #449

wants to merge 11 commits into from

Conversation

gianalarcon
Copy link
Collaborator

@gianalarcon gianalarcon commented Mar 1, 2025

Task name here

Fixes #relevant-issue-here

  • Updated GitHub workflow configuration to automatically adapt to new dependency versions.
  • Successfully performed comprehensive script testing and manual verification
    image
  • Maintained/kept starknet-devnet 2.3.0 version to prevent warning messages

Types of change

  • Feature
  • Bug
  • Enhancement

Comments (optional)

@gianalarcon gianalarcon requested a review from Nadai2010 March 1, 2025 17:49
@gianalarcon gianalarcon requested a review from jrcarlos2000 March 1, 2025 20:21
@gianalarcon gianalarcon marked this pull request as ready for review March 1, 2025 20:21
Copy link
Collaborator

@Nadai2010 Nadai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the change to the action. These updates improve the workflow by using GitHub Actions for installing tools (setup-scarb and setup-snfoundry) instead of custom scripts.

I've also tested with devnet version 0.2.4/0.2.3, scarb 2.10.1, and snfoundry 0.38.0, in preparation for the mainnet release 0.14.0 on March 17th. Currently, devnet is not ready, as it is still in the following PR:

PR for update 0.13.4 devnetrs

However, it is working fine on Sepolia:

Sepolia Contract Link

imagen

So, the proposed change is the best option right now. The README should also be updated to reflect the new versions.

Once the ODBuild reviews are finished, it can be merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants