Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add deploy flag to Customize Your Own dApp #78

Merged
merged 6 commits into from
Jan 8, 2025

Conversation

Buuh2511
Copy link
Collaborator

@Buuh2511 Buuh2511 commented Jan 7, 2025

Add deploy flag to Customize Your Own dApp & Add note for yarn chain fork

Types of change

  • Bug
  • Enhancement

Comments (optional)

@Buuh2511 Buuh2511 requested a review from jrcarlos2000 January 7, 2025 10:02
```

- If you wanna use events, **MAKE SURE** the fromBlock : is > the number in console + 1, otherwise the events data will always be empty. i.e. do not capture the first block of the fork
![Image description](../../static/img/warning-fork-block-number.png)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why dont we use embedded code here rather than a picture ?

```typescript
const scaffoldConfig = {
targetNetworks: [chains.mainnetFork],
isFork: true, // handles forked network validation
isFork: true, // handles forked network validation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this doesnt exist anymore

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gm, so need to remove isFork: true, right sir ?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove this file

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hello sir. i just push a commit that remove this file

@0xquantum3labs 0xquantum3labs merged commit 4a0e951 into main Jan 8, 2025
1 check passed
@0xquantum3labs 0xquantum3labs deleted the bu/update-deploy-flag branch January 8, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants