Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update instructions for renaming and deploying smart contract #98

Conversation

Oladayo-Ahmod
Copy link
Contributor

[DOCS] Add Instructions on How to Change the Smart Contract Name

Fixes #94

Types of change

  • Bug
  • Enhancement

Comments (optional)

This PR updates the deploy-smart-contract.mdx documentation to clarify how to rename a Cairo smart contract and correctly deploy it using the deploy.ts script.

@Oladayo-Ahmod
Copy link
Contributor Author

Oladayo-Ahmod commented Jan 28, 2025

@Nadai2010 Please, check.

Copy link
Collaborator

@Nadai2010 Nadai2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello @Oladayo-Ahmod thank you very much for your work.

I think it would be advisable to add also with contractName, so you could display the same contract with another name and/or several contracts with different names.

https://github.com/Scaffold-Stark/scaffold-stark-2/blob/main/packages/snfoundry/scripts-ts/deploy.ts#L17

@Oladayo-Ahmod
Copy link
Contributor Author

Thanks for your feedback @Nadai2010 . I have implemented the suggestion, you can re-check now.

@Nadai2010 Nadai2010 merged commit 199c82a into Scaffold-Stark:main Feb 4, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DOCS] Add Instructions on How to Change the Smart Contract Name
2 participants