Skip to content

Commit

Permalink
maybe something to do with order of middleware. CORs headers not pres…
Browse files Browse the repository at this point in the history
…ent in final response which is its whole point of existing in middleware?
  • Loading branch information
GondekNP committed Dec 13, 2024
1 parent 7c0837f commit b8245d7
Showing 1 changed file with 21 additions and 21 deletions.
42 changes: 21 additions & 21 deletions src/burn_backend/app.py
Original file line number Diff line number Diff line change
Expand Up @@ -86,35 +86,35 @@
## Debug: Log incoming request origins, to help debug CORS issues, also log outgoing


class ResponseLoggingMiddleware(BaseHTTPMiddleware):
async def dispatch(self, request: Request, call_next):
response = await call_next(request)
logger = get_cloud_logger()
# class ResponseLoggingMiddleware(BaseHTTPMiddleware):
# async def dispatch(self, request: Request, call_next):
# response = await call_next(request)
# logger = get_cloud_logger()

# Log response details
logger.info(f"Outgoing response status: {response.status_code}")
logger.info(f"Outgoing response headers: {dict(response.headers)}")
# # Log response details
# logger.info(f"Outgoing response status: {response.status_code}")
# logger.info(f"Outgoing response headers: {dict(response.headers)}")

return response
# return response


app.add_middleware(ResponseLoggingMiddleware)
# app.add_middleware(ResponseLoggingMiddleware)


@app.middleware("http")
async def log_request_origin(request, call_next):
origin = request.headers.get("origin")
logger = get_cloud_logger()
logger.info(f"Incoming request origin: {origin}")
logger.info(f"Configured allowed origins: {ALLOWED_ORIGINS}")
# @app.middleware("http")
# async def log_request_origin(request, call_next):
# origin = request.headers.get("origin")
# logger = get_cloud_logger()
# logger.info(f"Incoming request origin: {origin}")
# logger.info(f"Configured allowed origins: {ALLOWED_ORIGINS}")

if origin and origin not in ALLOWED_ORIGINS:
fastapi_logger.warning(
f"Origin {origin} not in allowed origins: {ALLOWED_ORIGINS}"
)
# if origin and origin not in ALLOWED_ORIGINS:
# fastapi_logger.warning(
# f"Origin {origin} not in allowed origins: {ALLOWED_ORIGINS}"
# )

response = await call_next(request)
return response
# response = await call_next(request)
# return response


app.add_middleware(
Expand Down

0 comments on commit b8245d7

Please sign in to comment.