Skip to content

Commit

Permalink
fix: basic-auth support for servicemonitor (#109)
Browse files Browse the repository at this point in the history
* feat: add basic-auth support for servicemonitor

Signed-off-by: Felix Kammerer <felix.kammerer@mail.schwarz>

Co-authored-by: Felix Kammerer <felix.kammerer@mail.schwarz>
Co-authored-by: Engin Diri <engin.diri@ediri.de>
  • Loading branch information
3 people authored Apr 19, 2022
1 parent 56cf06b commit 3ca8cb2
Show file tree
Hide file tree
Showing 3 changed files with 9 additions and 7 deletions.
4 changes: 2 additions & 2 deletions charts/node-red/Chart.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ icon: https://nodered.org/about/resources/media/node-red-icon-2.png

type: application

version: 0.17.0
version: 0.17.1
appVersion: 2.2.2

keywords:
Expand All @@ -29,7 +29,7 @@ maintainers:
annotations:
artifacthub.io/containsSecurityUpdates: "false"
artifacthub.io/changes: |
- remove initContainer and work with runAsUser and fsGroup
- change servicemonitor flag from list to object
artifacthub.io/images: |
- name: node-red
image: docker.io/nodered/node-red:2.2.2
Expand Down
10 changes: 6 additions & 4 deletions charts/node-red/README.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
# node-red ⚙

![Version: 0.16.0](https://img.shields.io/badge/Version-0.16.0-informational?style=for-the-badge)
![Version: 0.17.1](https://img.shields.io/badge/Version-0.17.1-informational?style=for-the-badge)
![Type: application](https://img.shields.io/badge/Type-application-informational?style=for-the-badge)
![AppVersion: 2.2.2](https://img.shields.io/badge/AppVersion-2.2.2-informational?style=for-the-badge)

Expand All @@ -27,7 +27,7 @@ helm repo update
To install the chart with the release name node-red run:

```bash
helm install node-red node-red/node-red --version 0.16.0
helm install node-red node-red/node-red --version 0.17.1
```

After a few seconds, node-red should be running.
Expand Down Expand Up @@ -79,7 +79,7 @@ The command removes all the Kubernetes components associated with the chart and
| metrics.enabled | bool | `false` | Deploy metrics service |
| metrics.path | string | `"/metrics"` | |
| metrics.serviceMonitor.additionalLabels | object | `{}` | Prometheus ServiceMonitor labels |
| metrics.serviceMonitor.basicAuth | list | `[]` | Prometheus basicAuth configuration for ServiceMonitor endpoint |
| metrics.serviceMonitor.basicAuth | object | `{}` | Prometheus basicAuth configuration for ServiceMonitor endpoint |
| metrics.serviceMonitor.enabled | bool | `false` | Enable a prometheus ServiceMonitor |
| metrics.serviceMonitor.interval | string | `"30s"` | Prometheus ServiceMonitor interval |
| metrics.serviceMonitor.metricRelabelings | list | `[]` | Prometheus [MetricRelabelConfigs] to apply to samples before ingestion |
Expand All @@ -94,7 +94,9 @@ The command removes all the Kubernetes components associated with the chart and
| persistence.enabled | bool | `false` | Use persistent volume to store data |
| persistence.size | string | `"5Gi"` | Size of persistent volume claim |
| podAnnotations | object | `{}` | Pod annotations |
| podSecurityContext | object | `{}` | Pod Security Context see [values.yaml](values.yaml) |
| podSecurityContext | object | `{"fsGroup":1000,"runAsUser":1000}` | Pod Security Context see [values.yaml](values.yaml) |
| podSecurityContext.fsGroup | int | `1000` | node-red group is 1000 |
| podSecurityContext.runAsUser | int | `1000` | node-red user is 1000 |
| replicaCount | int | `1` | Number of nodes |
| resources | object | `{}` | CPU/Memory resource requests/limits |
| securityContext | object | `{}` | Security Context see [values.yaml](values.yaml) |
Expand Down
2 changes: 1 addition & 1 deletion charts/node-red/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ metrics:
# -- Enable a prometheus ServiceMonitor
enabled: false
# -- Prometheus basicAuth configuration for ServiceMonitor endpoint
basicAuth: []
basicAuth: {}
# -- Prometheus ServiceMonitor interval
interval: 30s
# -- Prometheus [RelabelConfigs] to apply to samples before scraping
Expand Down

0 comments on commit 3ca8cb2

Please sign in to comment.