fix: add missing quotes to create valid yaml (#261)

* fix: add missing quotes to create valid yaml Signed-off-by: Engin Diri <engin.diri@ediri.de> * fix: add missing quotes to create valid yaml Signed-off-by: Engin Diri <engin.diri@ediri.de> --------- Signed-off-by: Engin Diri <engin.diri@ediri.de>
SchwarzIT · Jul 16, 2023 · e3ad5ef · e3ad5ef
1 parent 91fa873
commit e3ad5ef
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/charts/node-red/Chart.yaml b/charts/node-red/Chart.yaml
@@ -9,7 +9,7 @@ icon: https://nodered.org/about/resources/media/node-red-icon-2.png
 
 type: application
 
-version: 0.24.3
+version: 0.24.4
 appVersion: 3.0.2
 
 keywords:
@@ -29,7 +29,7 @@ maintainers:
 annotations:
   artifacthub.io/containsSecurityUpdates: "false"
   artifacthub.io/changes: |
-    - update quay.io/kiwigrid/k8s-sidecar to 1.25.0
+    - add missing quotes to create valid yaml
   artifacthub.io/images: |
     - name: node-red
       image: docker.io/nodered/node-red:3.0.2

diff --git a/charts/node-red/README.md b/charts/node-red/README.md
@@ -1,6 +1,6 @@
 # node-red ⚙
 
-![Version: 0.24.3](https://img.shields.io/badge/Version-0.24.3-informational?style=for-the-badge) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=for-the-badge) ![AppVersion: 3.0.2](https://img.shields.io/badge/AppVersion-3.0.2-informational?style=for-the-badge)
+![Version: 0.24.4](https://img.shields.io/badge/Version-0.24.4-informational?style=for-the-badge) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=for-the-badge) ![AppVersion: 3.0.2](https://img.shields.io/badge/AppVersion-3.0.2-informational?style=for-the-badge)
 
 [![Artifact Hub](https://img.shields.io/endpoint?url=https://artifacthub.io/badge/repository/node-red&style=for-the-badge)](https://artifacthub.io/packages/search?repo=node-red)
 [![SIT](https://img.shields.io/badge/SIT-awesome-blueviolet.svg?style=for-the-badge)](https://jobs.schwarz)
@@ -16,7 +16,7 @@ A Helm chart for Node-Red, a low-code programming for event-driven applications
 To install the chart using the OCI artifact, run:
 
 ```bash
-helm install node-red oci://ghcr.io/schwarzit/charts/node-red --version 0.24.3
+helm install node-red oci://ghcr.io/schwarzit/charts/node-red --version 0.24.4
 ```
 
 ## Usage
@@ -32,7 +32,7 @@ helm repo update
 To install the chart with the release name node-red run:
 
 ```bash
-helm install node-red node-red/node-red --version 0.24.3
+helm install node-red node-red/node-red --version 0.24.4
 ```
 
 After a few seconds, node-red should be running.

diff --git a/charts/node-red/templates/sidecar-cm.yaml b/charts/node-red/templates/sidecar-cm.yaml
@@ -11,5 +11,5 @@ kind: ConfigMap
 metadata:
   name: {{ include "node-red.sidecarConfigMapName" . }}
   labels:
-    {{ .Values.sidecar.env.label}}: {{ .Values.sidecar.env.label_value}}
-{{- end }}
+    {{ .Values.sidecar.env.label}}: {{ .Values.sidecar.env.label_value | quote}}
+{{- end }}
diff --git a/charts/node-red/tests/flow_refresh_cm_test.yaml b/charts/node-red/tests/flow_refresh_cm_test.yaml
@@ -21,7 +21,7 @@ tests:
     asserts:
       - equal:
           path: metadata.labels.node-red-settings
-          value: 1
+          value: "1"
   - it: check that data is not empty
     values:
       - ./values/sidecar_values.yaml