-
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Try updating compats #250
Try updating compats #250
Conversation
All tests except threshold should pass. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #250 +/- ##
===========================================
- Coverage 92.02% 78.81% -13.22%
===========================================
Files 7 7
Lines 439 439
===========================================
- Hits 404 346 -58
- Misses 35 93 +58 ☔ View full report in Codecov by Sentry. |
This assumes that the cost function is intended to return a scalar, which should always be true as far as I know. The tuple stuff was because of a weird REPL state that I had where There's still one more thing to fix in |
Is it not using the latest Integrals.jl? |
My manifest says |
I just needed to get rid of the |
Tests pass locally now. Looks like the tests for datafit passed, but there was an issue in code coverage, which caused the core tests to abort. |
Checklist
contributor guidelines, in particular the SciML Style Guide and
COLPRAC.
Additional context
Add any other context about the problem here.