Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

anaconda3: Fix setup.exe not found error #10835

Merged
merged 1 commit into from
Mar 25, 2023

Conversation

silicer
Copy link
Contributor

@silicer silicer commented Mar 24, 2023

Closes #10833

@silicer
Copy link
Contributor Author

silicer commented Mar 24, 2023

/verify

@github-actions
Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

anaconda3

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Copy link
Contributor

@jasongodev jasongodev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't recommend merging until the reason for moving the setup.exe file to another directory is established, see PR #10830.

@@ -21,7 +21,7 @@
"Move-Item \"$dir\\setup.exe\" \"$dir\\..\\setup.exe\" | Out-Null",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A recent merged #10830 about 2 days ago was done that added this line. Let's see what is the rationale for moving the setup.exe to another path. If this line is needed then your PR is also needed.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ref: #10829

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but moving setup.exe to the parent directory did solve my installation issue. The setup.exe suddenly ends after verifying 100% before. #10829

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

conda now requires an empty dir to install

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure where we discuss the issue on too many references

@jasongodev
Copy link
Contributor

For context, miniconda does have the path like this:

"Start-Process \"$dir\\..\\setup.exe\" -ArgumentList @('/S', '/InstallationType=JustMe', '/RegisterPython=0', '/AddToPath=0', '/NoRegistry=1', \"/D=$dir\") -Wait | Out-Null"

@niheaven niheaven changed the title anaconda3: fix setup.exe not found error anaconda3: Fix setup.exe not found error Mar 25, 2023
@niheaven niheaven merged commit fa862c4 into ScoopInstaller:master Mar 25, 2023
@Lutra-Fs
Copy link
Contributor

Am I rename the installer?

@jasongodev
Copy link
Contributor

Am I rename the installer?

I don't think it's necessary. Also, this PR was merged already. So all is well until the next issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: failed to install anaconda3 due to path error
4 participants