-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
anaconda3: Fix setup.exe not found error #10835
Conversation
/verify |
All changes look good. Wait for review from human collaborators. anaconda3
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't recommend merging until the reason for moving the setup.exe file to another directory is established, see PR #10830.
@@ -21,7 +21,7 @@ | |||
"Move-Item \"$dir\\setup.exe\" \"$dir\\..\\setup.exe\" | Out-Null", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A recent merged #10830 about 2 days ago was done that added this line. Let's see what is the rationale for moving the setup.exe to another path. If this line is needed then your PR is also needed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ref: #10829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why but moving setup.exe
to the parent directory did solve my installation issue. The setup.exe
suddenly ends after verifying 100% before. #10829
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
conda now requires an empty dir to install
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not sure where we discuss the issue on too many references
For context, miniconda does have the path like this: Line 24 in 14249cd
|
Am I rename the installer? |
I don't think it's necessary. Also, this PR was merged already. So all is well until the next issue. |
Closes #10833