eac3to@3.50: update from 3.36 #5501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
coolpringles
commented
Feb 5, 2024
coolpringles
commented
- I have read the Contributing Guide.
|
/verify |
|
Your changes do not pass checks. eac3to
|
|
/verify |
|
Your changes do not pass checks. eac3to
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. eac3to
|
|
I did not mean to do that |
|
/verify |
|
Your changes do not pass checks. eac3to
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. eac3to
|
tech189
requested changes
Mar 7, 2024
There was a problem hiding this comment.
Hi, thanks for this update, could you please:
- restore autoupdate (point to the same url as checkver but add on the end
https://www.rationalqm.us/eac3to/eac3to_$version.rar - reorder the manifest to the regular order here: https://github.com/ScoopInstaller/.github/blob/main/.github/CONTRIBUTING.md#for-scoop-buckets
- restore the same number of spaces for indentation as standard for all manifests (4) - this is set in
.editorconfigif your editor checks that
coolpringles
changed the title
tech189
approved these changes
Mar 8, 2024
|
/verify |
|
Your changes do not pass checks. eac3to
|
|
/verify |
|
All changes look good. Wait for review from human collaborators. eac3to
|
|
Thanks for your contribution! For reference, this PR updates the download, checkver, and autoupdate to www.rationalqm.us as it says on the old forum post:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.