Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

croc: Update to version 9.6.11, fix autoupdate #5513

Merged
merged 3 commits into from
Mar 12, 2024

Conversation

aliesbelik
Copy link
Contributor

  • Update to version 9.6.9.

  • Fix autoupdate urls.

  • Remove arm64 option (since not available in the recent releases).

  • I have read the Contributing Guide.

@aliesbelik
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

croc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

croc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@tech189
Copy link
Member

tech189 commented Feb 19, 2024

I filed an issue to determine whether they might add the releases in future: schollz/croc#664

Edit: looks like they just pushed a fix to the build system, shall we wait until the next release to fix autoupdate?

@aliesbelik aliesbelik changed the title croc: Update to version 9.6.9, fix autoupdate, remove arm64 option croc: Update to version 9.6.11, fix autoupdate Feb 19, 2024
@aliesbelik
Copy link
Contributor Author

aliesbelik commented Feb 19, 2024

I filed an issue to determine whether they might add the releases in future: schollz/croc#664

Edit: looks like they just pushed a fix to the build system, shall we wait until the next release to fix autoupdate?

Thank you for being proactive.
Brought arm64 version back, updated to the latest version.

Looks like change to v$version in binaries names is actual for at least 5 last releases, so I leave the changes for autoupdate as they are.

@aliesbelik
Copy link
Contributor Author

/verify

Copy link
Contributor

All changes look good.

Wait for review from human collaborators.

croc

  • Description
  • License
  • Hashes
  • Checkver
  • Autoupdate
  • Autoupdate Hash Extraction

@tech189
Copy link
Member

tech189 commented Feb 20, 2024

Current version (v9.6.12) is not working at the moment so let's delay pushing this
schollz/croc#668

@tech189
Copy link
Member

tech189 commented Mar 12, 2024

Version 9.6.14 works now, so LGTM!

@tech189 tech189 merged commit 2919dbd into ScoopInstaller:master Mar 12, 2024
2 checks passed
@aliesbelik aliesbelik deleted the croc-fix branch March 12, 2024 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants