Expanded the testcase for GRPlatform>>secureHashFor: #182
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The method
GRPlatform>>secureHashFor:
accepts both aString
and aByteArray
as argument. The contents of theByteArray
can be any sequence of bytes, so it should not represent a valid UTF8 encodedString
(for example).In this PR, we extend the test case to also cover the use of a
ByteArray
.In Seaside, all invocations of the method always passed a
String
instance as argument, until the e-tag implementation for the file libraries, which also uses it to generate a hash for any served file, which may include binary files (e.g. images). See SeasideSt/Seaside#1325.