Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Store WiFi credentials via preferences #50

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidkreidler
Copy link

Add the option to load the WiFi credentials on boot. Before this change the user needed to input the WiFi SSID / password every time the device was rebooted. Tested on a ESP32-S3.

Add the option to load the wifi credentials on boot. Before this change the user needed to input the wifi ssid/password every time the device was rebooted. Tested on a ESP32-S3.
@LeonieFierz
Copy link
Member

Dear @davidkreidler
Thank you for your contribution!
I had a look at the code and unfortunately we cannot merge it into master. One reason is security concerns with storing WiFi Credentials plain text in the settings.
The other thing is that storing the WiFi credentials should be handled by the caller and not be part of the WiFi Lib Wrapper to keep the Wrapper tidy.
Best, Léonie

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants