Added data checking option: search for notes and sources without links

Serg-Norseman · Jun 7, 2024 · 67d2973 · 67d2973
1 parent 6ed1910
commit 67d2973
Show file tree

Hide file tree

Showing 30 changed files with 324 additions and 140 deletions.
diff --git a/locales/Afrikaans.lng b/locales/Afrikaans.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Belarusian.lng b/locales/Belarusian.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Chinese Simplified.lng b/locales/Chinese Simplified.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Dutch.lng b/locales/Dutch.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/English.lng b/locales/English.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Hungarian.lng b/locales/Hungarian.lng
@@ -966,3 +966,6 @@
 956=Kép gyorsítótár törlés
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Icelandic.lng b/locales/Icelandic.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Japanese.lng b/locales/Japanese.lng
@@ -966,3 +966,6 @@
 956=画像のキャッシュを消去する
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Kazakh (Cyrillic).lng b/locales/Kazakh (Cyrillic).lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Portuguese.lng b/locales/Portuguese.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Serbian (Latin).lng b/locales/Serbian (Latin).lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/Spanish.lng b/locales/Spanish.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/czech.lng b/locales/czech.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/french.lng b/locales/french.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/german.lng b/locales/german.lng
@@ -966,3 +966,6 @@
 956=Bilder-Cache leeren
 957=Auswahllinien hervorheben
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/help_enu/gkhHistory.html b/locales/help_enu/gkhHistory.html
@@ -12,6 +12,7 @@ <h1>Change log</h1>
 
     <p>
         <b>14.06.2024 [v2.30.1 &amp; v3.6.1]</b><ul>
+            <li>Added data checking option: search for notes and sources without links.
             <li>Added a call to detailed information about sources and persons in the lists of citations to sources, children, parents and spouses (pop-up menu).
             <li>Added display of multimedia and notes on the info-panel for events.
             <li>Fixed multiple lines in the Author column of source citation lists (GKv3).

diff --git a/locales/help_rus/gkhHistory.html b/locales/help_rus/gkhHistory.html
@@ -12,6 +12,7 @@ <h1>История версий</h1>
 
     <p>
         <b>14.06.2024 [v2.30.1 &amp; v3.6.1]</b><ul>
+            <li>Добавлена опция проверки данных: поиск записей заметок и источников без ссылок.
             <li>Добавлен вызов детальной информации об источниках и персонах в списки ссылок на источники, детей, родителей и супругов (всплывающее меню).
             <li>Добавлено отображение мультимедиа и заметок на инфо-панели для событий.
             <li>Устранены множественные строки в столбце "Автор" списков ссылок на источники (GKv3).

diff --git a/locales/italian.lng b/locales/italian.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/polish.lng b/locales/polish.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/locales/russian.lng b/locales/russian.lng
@@ -966,3 +966,6 @@
 956=Очистить кеш изображений
 957=Подсветка линий выделенного
 958=Отслеживать совпадающие источники
+959=Заметка без ссылок
+960=Источник без ссылок
+961=Проверить связи
diff --git a/locales/ukrainian.lng b/locales/ukrainian.lng
@@ -966,3 +966,6 @@
 956=Clean images cache
 957=Highlight the lines of the selection
 958=Track matching sources
+959=Note without links
+960=Source without links
+961=Check links
diff --git a/projects/GKCore/GKCore/Controllers/TreeCheckController.cs b/projects/GKCore/GKCore/Controllers/TreeCheckController.cs
@@ -1,6 +1,6 @@
 /*
  *  "GEDKeeper", the personal genealogical database editor.
- *  Copyright (C) 2009-2023 by Sergey V. Zhdanovskih.
+ *  Copyright (C) 2009-2024 by Sergey V. Zhdanovskih.
  *
  *  This file is part of "GEDKeeper".
  *
@@ -54,6 +54,7 @@ public void CheckBase()
         {
             fOptions.CheckIndividualPlaces = GetControl<ICheckBox>("chkCheckPersonPlaces").Checked;
             fOptions.CheckCensuses = GetControl<ICheckBox>("chkCheckCensuses").Checked;
+            fOptions.CheckLinks = GetControl<ICheckBox>("chkCheckLinks").Checked;
 
             AppHost.Instance.ExecuteWork((controller) => {
                 TreeInspector.CheckBase(fBase, fChecksList, controller, fOptions);
@@ -170,6 +171,7 @@ public override void SetLocale()
             GetControl<ITabPage>("pageOptions").Text = LangMan.LS(LSID.MIOptions);
             GetControl<ICheckBox>("chkCheckPersonPlaces").Text = LangMan.LS(LSID.CheckPersonPlaces);
             GetControl<ICheckBox>("chkCheckCensuses").Text = LangMan.LS(LSID.CensusAnalysis);
+            GetControl<ICheckBox>("chkCheckLinks").Text = LangMan.LS(LSID.CheckLinks);
 
             fView.ChecksList.AddColumn(LangMan.LS(LSID.Record), 400, false);
             fView.ChecksList.AddColumn(LangMan.LS(LSID.Problem), 200, false);

diff --git a/projects/GKCore/GKCore/LangMan.cs b/projects/GKCore/GKCore/LangMan.cs
@@ -1030,8 +1030,11 @@ public enum LSID
         /* 956 */ CleanImagesCache,
         /* 957 */ TrackSelectedLines,
         /* 958 */ TrackMatchedSources,
+        /* 959 */ NoteWithoutLinks,
+        /* 960 */ SourceWithoutLinks,
+        /* 961 */ CheckLinks,
 
-        /* 000 */ Last = TrackMatchedSources
+        /* 000 */ Last = CheckLinks
     }
 
 
@@ -2015,6 +2018,9 @@ public static class LangMan
             /* 956 */ "Clean images cache",
             /* 957 */ "Highlight the lines of the selection",
             /* 958 */ "Track matching sources",
+            /* 959 */ "Note without links",
+            /* 960 */ "Source without links",
+            /* 961 */ "Check links",
         };
 
         private static readonly LangManager fLangMan = new LangManager();

diff --git a/projects/GKCore/GKCore/Tools/TreeInspector.cs b/projects/GKCore/GKCore/Tools/TreeInspector.cs
@@ -1,6 +1,6 @@
 /*
  *  "GEDKeeper", the personal genealogical database editor.
- *  Copyright (C) 2009-2023 by Sergey V. Zhdanovskih.
+ *  Copyright (C) 2009-2024 by Sergey V. Zhdanovskih.
  *
  *  This file is part of "GEDKeeper".
  *
@@ -35,6 +35,7 @@ public class TreeInspectionOptions
     {
         public bool CheckIndividualPlaces;
         public bool CheckCensuses;
+        public bool CheckLinks;
     }
 
     /// <summary>
@@ -74,6 +75,8 @@ public enum CheckDiag
             cdHighSpousesDifference,
             cdHighSiblingsDifference,
             cdMatchedCensus,
+            cdNoteWithoutLinks,
+            cdSourceWithoutLinks,
         }
 
         public enum CheckSolve
@@ -121,6 +124,14 @@ public string GetRecordName(GDMTree tree)
                     case GDMRecordType.rtFamily:
                         result = GKUtils.GetFamilyString(tree, (GDMFamilyRecord)Rec);
                         break;
+
+                    case GDMRecordType.rtNote:
+                        result = ((GDMNoteRecord)Rec).Lines[0]; // TODO: bad solution?!
+                        break;
+
+                    case GDMRecordType.rtSource:
+                        result = ((GDMSourceRecord)Rec).ShortTitle;
+                        break;
                 }
 
                 result = string.Concat(result, " [ ", Rec.XRef, " ]");
@@ -470,6 +481,85 @@ private static void CheckMultimediaRecord(IBaseContext baseContext, GDMMultimedi
             }
         }
 
+        private static bool CheckStructLinks(IGDMStructWithLists strWL, GDMRecord subject)
+        {
+            switch (subject.RecordType) {
+                case GDMRecordType.rtNote:
+                    if (strWL.HasNotes) {
+                        for (int i = 0, num = strWL.Notes.Count; i < num; i++) {
+                            if (strWL.Notes[i].XRef == subject.XRef) {
+                                return true;
+                            }
+                        }
+                    }
+                    break;
+
+                case GDMRecordType.rtMultimedia:
+                    if (strWL.HasMultimediaLinks) {
+                        for (int i = 0, num = strWL.MultimediaLinks.Count; i < num; i++) {
+                            if (strWL.MultimediaLinks[i].XRef == subject.XRef) {
+                                return true;
+                            }
+                        }
+                    }
+                    break;
+
+                case GDMRecordType.rtSource:
+                    if (strWL.HasSourceCitations) {
+                        for (int i = 0, num = strWL.SourceCitations.Count; i < num; i++) {
+                            var sourCit = strWL.SourceCitations[i];
+                            if (sourCit.XRef == subject.XRef) {
+                                return true;
+                            }
+                        }
+                    }
+                    break;
+            }
+
+            return false;
+        }
+
+        private static bool CheckRecordLinks(IBaseContext baseContext, GDMRecord subject)
+        {
+            var tree = baseContext.Tree;
+            for (int k = 0, num2 = tree.RecordsCount; k < num2; k++) {
+                GDMRecord record = tree[k];
+
+                if (CheckStructLinks(record, subject))
+                    return true;
+
+                var evsRec = record as GDMRecordWithEvents;
+                if (evsRec != null && evsRec.HasEvents) {
+                    for (int i = 0, num = evsRec.Events.Count; i < num; i++) {
+                        if (CheckStructLinks(evsRec.Events[i], subject))
+                            return true;
+                    }
+                }
+            }
+
+            return false;
+        }
+
+        private static void CheckNoteRecord(IBaseContext baseContext, GDMNoteRecord noteRec, List<CheckObj> checksList)
+        {
+            if (!CheckRecordLinks(baseContext, noteRec)) {
+                CheckObj checkObj = new CheckObj(noteRec, CheckDiag.cdNoteWithoutLinks, CheckSolve.csRemove);
+                checkObj.Comment = LangMan.LS(LSID.NoteWithoutLinks);
+                checksList.Add(checkObj);
+                return;
+            }
+        }
+
+        private static void CheckSourceRecord(IBaseContext baseContext, GDMSourceRecord sourRec, List<CheckObj> checksList)
+        {
+            if (!CheckRecordLinks(baseContext, sourRec)) {
+                CheckObj checkObj = new CheckObj(sourRec, CheckDiag.cdSourceWithoutLinks, CheckSolve.csRemove);
+                checkObj.Comment = LangMan.LS(LSID.SourceWithoutLinks);
+                checksList.Add(checkObj);
+                return;
+            }
+        }
+
         public static void CheckBase(IBaseWindow baseWin, List<CheckObj> checksList, IProgressController progress, TreeInspectionOptions options = null)
         {
             if (baseWin == null)
@@ -501,6 +591,14 @@ public static void CheckBase(IBaseWindow baseWin, List<CheckObj> checksList, IPr
                         case GDMRecordType.rtMultimedia:
                             CheckMultimediaRecord(baseWin.Context, rec as GDMMultimediaRecord, checksList);
                             break;
+
+                        case GDMRecordType.rtNote:
+                            if (options.CheckLinks) CheckNoteRecord(baseWin.Context, rec as GDMNoteRecord, checksList);
+                            break;
+
+                        case GDMRecordType.rtSource:
+                            if (options.CheckLinks) CheckSourceRecord(baseWin.Context, rec as GDMSourceRecord, checksList);
+                            break;
                     }
                 }
             } finally {
@@ -654,6 +752,11 @@ public static async Task RepairProblem(IView owner, IBaseWindow baseWin, CheckOb
                         CheckAndRepairGarbledSpouses(tree, famRec);
                     }
                     break;
+
+                case CheckDiag.cdNoteWithoutLinks:
+                case CheckDiag.cdSourceWithoutLinks:
+                    tree.DeleteRecord(checkObj.Rec);
+                    break;
             }
         }