Fix linter issues

ServiceWeaver · Aug 23, 2024 · 4215989 · 4215989
1 parent 604488a
commit 4215989
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 7 deletions.
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
@@ -85,7 +85,7 @@ jobs:
         if: ${{ matrix.command == 'lint' }}
 
       - name: Install linter
-        run: go install honnef.co/go/tools/cmd/staticcheck@v0.4.6
+        run: go install honnef.co/go/tools/cmd/staticcheck@v0.5.0
         if: ${{ matrix.command == 'lint' }}
 
       - name: Build the weaver binary

diff --git a/cmd/weaver/main.go b/cmd/weaver/main.go
@@ -165,7 +165,7 @@ func run(deployer string, args []string) (int, error) {
 	binary := "weaver-" + deployer
 	if _, err := exec.LookPath(binary); err != nil {
 		msg := fmt.Sprintf(`"weaver %s" is not a weaver command. See "weaver --help". If you're trying to invoke a custom deployer, the %q binary was not found. You may need to install the %q binary or add it to your PATH.`, deployer, binary, binary)
-		return 1, fmt.Errorf(wrap(msg, 80))
+		return 1, fmt.Errorf("%s", wrap(msg, 80))
 	}
 	cmd := exec.Command(binary, args...)
 	cmd.Stdin = os.Stdin

diff --git a/dev/build_and_test b/dev/build_and_test
@@ -54,7 +54,7 @@ function cmd_vet() {
 
 function cmd_lint() {
   if ! exists staticcheck; then
-    printf "staticcheck not found; install via\ngo install honnef.co/go/tools/cmd/staticcheck@v0.4.6\n" >&2
+    printf "staticcheck not found; install via\ngo install honnef.co/go/tools/cmd/staticcheck@v0.5.0\n" >&2
     exit 1
   fi
 

diff --git a/internal/net/call/stub_test.go b/internal/net/call/stub_test.go
@@ -188,7 +188,7 @@ func TestErrorArgsNotEncoded(t *testing.T) {
 	})
 
 	if !strings.Contains(err.Error(), "decoder: unable to read") {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 }
 

diff --git a/runtime/codegen/encoder_test.go b/runtime/codegen/encoder_test.go
@@ -144,7 +144,7 @@ func TestErrorDecUnableToRead(t *testing.T) {
 		dec.Bool()
 	})
 	if !strings.Contains(err.Error(), "unable to read #bytes") {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 }
 
@@ -160,7 +160,7 @@ func TestErrorUnableToDecBool(t *testing.T) {
 		dec.Bool()
 	})
 	if !strings.Contains(err.Error(), "unable to decode bool") {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 }
 
@@ -176,7 +176,7 @@ func TestErrorUnableToDecBytes(t *testing.T) {
 		dec.Bytes()
 	})
 	if !strings.Contains(err.Error(), "unable to decode bytes; expected length") {
-		t.Fatalf(err.Error())
+		t.Fatal(err.Error())
 	}
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -188,7 +188,7 @@ func TestErrorArgsNotEncoded(t *testing.T) { @@
     	})
     	if !strings.Contains(err.Error(), "decoder: unable to read") {
-    		t.Fatalf(err.Error())
+    		t.Fatal(err.Error())
     	}
     }
@@ Expand Down @@