Rename control components. #704
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
ghemawat
commented
Jan 8, 2024
ghemawat
commented
- Rename the control.Controller component to control.WeaverControl (to distinguish it from the DeployerControl component). Consistently rename corresponding types in other packages.
- Introduce a control.DeployerControl component that will hold methods implemented by deployers. Remove the logger component and move LogBatch into control.DeployerControl.
- Do not make the multi deployer provide a full component implementation (by using "weaver generate"). Instead, just export its override under the non-overridden component name.
1. Rename the control.Controller component to control.WeaverControl (to distinguish it from the DeployerControl component). Consistently rename corresponding types in other packages. 2. Introduce a control.DeployerControl component that will hold methods implemented by deployers. Remove the logger component and move LogBatch into control.DeployerControl. 3. Do not make the multi deployer provide a full component implementation (by using "weaver generate"). Instead, just export its override under the non-overridden component name.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.