Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MTLS handling. #707

Merged
merged 3 commits into from
Jan 9, 2024
Merged

Fix MTLS handling. #707

merged 3 commits into from
Jan 9, 2024

Conversation

ghemawat
Copy link
Collaborator

@ghemawat ghemawat commented Jan 9, 2024

We were using the wrong component name when setting up group data structures for MTLS (because of Go's funny loop variable capture semantics). Fixed this.

Added a test that uses multi deployer with MTLS.

Increased timeout for the test from 4s to 10s.

We were using the wrong component name when setting up group data
structures for MTLS (because of Go's funny loop variable capture
semantics). Fixed this.

Added a test that uses multi deployer with MTLS.

Increased timeout for the test from 4s to 10s.
@ghemawat ghemawat requested a review from spetrovic77 January 9, 2024 19:30
Copy link
Contributor

@spetrovic77 spetrovic77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@ghemawat ghemawat merged commit ac3a856 into ServiceWeaver:main Jan 9, 2024
7 checks passed
@ghemawat ghemawat deleted the mtls branch January 9, 2024 20:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants