status: map weavelet id to pids for multi, single and ssh deployment.

[flouthoc]

As of now weaver logs shows the weavelet id but not pids and weaver multi status shows the respective pid but its hard to map weavelet id from the logs to the running process, following commit adds weavelet id with the pids of the components so its easier to debug.

[flouthoc]

@rgrandl @mwhittaker PTAL

[rgrandl]

Thank you for the change. This is a great idea.

You'll also need to fix the single deployer and the ssh deployer, because they use the same status package.

[flouthoc]

@rgrandl PTAL again. I have tested both single and multi deploy but I was not able to test ssh although I think my code changes should work without any issues. Do we have test for ssh in CI ? or should i setup ssh in my environment.

[flouthoc]

@rgrandl I might be able to test on ssh as well today, but irrespective of that I think PR is ready for a review again.

[flouthoc]

@rgrandl I might be able to test on ssh as well today, but irrespective of that I think PR is ready for a review again.

Well I configured ssh setup only to figure out there is no status command in ssh deployer at all, there is a dashboard command but it is a webview. @rgrandl is there any cli command in ssh which is equivalent to status.

[rgrandl]

Looks great. I tried the ssh deployer and it works too.

I think you need to update the dashboard as well. If you do weaver multi dashboard you will see an error.

These are the changes you need to do:

diff --git a/internal/status/dashboard.go b/internal/status/dashboard.go
index ca821c1..ef55fd6 100644
--- a/internal/status/dashboard.go
+++ b/internal/status/dashboard.go
@@ -54,10 +54,17 @@ var (
        deploymentHTML     string
        deploymentTemplate = template.Must(template.New("deployment").Funcs(template.FuncMap{
                "shorten": logging.ShortenComponent,
-               "pidjoin": func(pids []int64) string {
-                       s := make([]string, len(pids))
-                       for i, x := range pids {
-                               s[i] = fmt.Sprint(x)
+               "pidjoin": func(replicas []*Replica) string {
+                       s := make([]string, len(replicas))
+                       for i, x := range replicas {
+                               s[i] = fmt.Sprint(x.Pid)
+                       }
+                       return strings.Join(s, ", ")
+               },
+               "widjoin": func(replicas []*Replica) string {
+                       s := make([]string, len(replicas))
+                       for i, x := range replicas {
+                               s[i] = x.WeaveletId[0:8]
                        }
                        return strings.Join(s, ", ")
                },
diff --git a/internal/status/templates/deployment.html b/internal/status/templates/deployment.html
index 2ae661b..5753bbc 100644
--- a/internal/status/templates/deployment.html
+++ b/internal/status/templates/deployment.html
@@ -152,14 +152,16 @@
               <th>Component</th>
               <th>Replication</th>
               <th>PIDs</th>
+              <th>Weavelet IDs</th>
             </tr>
           </thead>
           <tbody>
             {{range $c := .Components}}
             <tr>
               <td>{{shorten $c.Name}}</td>
-              <td>{{len $c.Pids}}</td>
-              <td>{{pidjoin $c.Pids}}</td>
+              <td>{{len $c.Replicas}}</td>
+              <td>{{pidjoin $c.Replicas}}</td>
+              <td>{{widjoin $c.Replicas}}</td>
             </tr>
             {{end}}
           </tbody>

[rgrandl]

I think we should let it crash here. If we don't set the weavelet id somehow, we shouldn't hide it.

[flouthoc]

@rgrandl Please take a look again.

[rgrandl]

Looks great! Thanks a lot!

[rgrandl]

@rgrandl I might be able to test on ssh as well today, but irrespective of that I think PR is ready for a review again.

Well I configured ssh setup only to figure out there is no status command in ssh deployer at all, there is a dashboard command but it is a webview. @rgrandl is there any cli command in ssh which is equivalent to status.

There is no status command in the ssh deployer apparently.

[rgrandl]

@flouthoc can you also run ./dev/build_and_test tidy generate build vet test testrace