Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turndown message #803

Merged
merged 2 commits into from
Nov 7, 2024
Merged

Turndown message #803

merged 2 commits into from
Nov 7, 2024

Conversation

rgrandl
Copy link
Contributor

@rgrandl rgrandl commented Nov 5, 2024

No description provided.

@rgrandl rgrandl self-assigned this Nov 5, 2024
README.md Outdated
</p>
<p style="color: inherit">We greatly appreciate the continued advocacy and support
of the Service Weaver community. However, we have learned what we needed from
our exploration, and we regret to announce that, <b>effective December 5, 2024,
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alternate wording suggestion:

However, we realized that it was hard for users to adopt Service Weaver directly since it required rewriting large parts of existing applications. Therefore Service Weaver did not see much direct use and therefore effective ...

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the text.

@@ -27,6 +27,13 @@ <h1>
<a href="docs.html">Read the Docs</a>
</div>

<div class="announcement-banner">
<p>We regret to announce that, effective <b>December 5, 2024</b>, we will no longer be able to
continue active development on the Service Weaver open-source framework. For more details, click
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/no longer be able to continue active/no longer continue/

README.md Outdated
<p style="color: inherit">We greatly appreciate the continued advocacy and support
of the Service Weaver community. However, we have learned what we needed from
our exploration, and we regret to announce that, <b>effective December 5, 2024,
we will transition Service Weaver into maintenance mode</b>. We recommend that users
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The sentence "We recommend that..." is a bit in the way of the overall flow. I think it can be removed, or maybe moved to the end of this paragraph.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Yeah, I felt the same. However, we should let users know what would be a better approach maybe (to fork the repo). I moved that sentence to the end of the paragraph.

Copy link
Contributor Author

@rgrandl rgrandl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the feedback

README.md Outdated
</p>
<p style="color: inherit">We greatly appreciate the continued advocacy and support
of the Service Weaver community. However, we have learned what we needed from
our exploration, and we regret to announce that, <b>effective December 5, 2024,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated the text.

README.md Outdated
<p style="color: inherit">We greatly appreciate the continued advocacy and support
of the Service Weaver community. However, we have learned what we needed from
our exploration, and we regret to announce that, <b>effective December 5, 2024,
we will transition Service Weaver into maintenance mode</b>. We recommend that users
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. Yeah, I felt the same. However, we should let users know what would be a better approach maybe (to fork the repo). I moved that sentence to the end of the paragraph.

@rgrandl rgrandl merged commit ea7473a into main Nov 7, 2024
10 checks passed
@rgrandl rgrandl deleted the weaver_turndown branch November 7, 2024 17:18
rgrandl added a commit that referenced this pull request Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants