Merge pull request #111 from Shopify/activesupport-7.2

Fix support for ActiveSupport 7.2 without Rails

.github/workflows/ci.yml

@@ -7,15 +7,19 @@ jobs:
     runs-on: ubuntu-latest
     name: Ruby ${{ matrix.ruby }} / ${{ matrix.gemfile }}
     strategy:
+      fail-fast: false
       matrix:
         gemfile:
           - Gemfile
           - gemfiles/activesupport_6.1.gemfile
           - gemfiles/activesupport_7.0.gemfile
           - gemfiles/activesupport_7.1.gemfile
+          - gemfiles/activesupport_7.2.gemfile
           - gemfiles/activesupport_edge.gemfile
         ruby: ["3.0", "3.1", "3.2", "3.3"]
         exclude:
+          - gemfile: gemfiles/activesupport_7.2.gemfile
+            ruby: "3.0"
           - gemfile: gemfiles/activesupport_edge.gemfile
             ruby: "3.0"
     env:

README.md

@@ -170,6 +170,10 @@ It's possible to record deprecations while running your specs by adding an ENV['
 DEPRECATION_BEHAVIOR="record" bundle exec rspec path/to/file_spec.rb
 ```
 
+## Usage without Rails
+
+Without Rails, you'll need to make sure your `ActiveSupport::Deprecation` instances use the [`:notify` behavior](https://api.rubyonrails.org/classes/ActiveSupport/Deprecation/Behavior.html#method-i-behavior-3D).
+
 ## License
 
 Deprecation Toolkit is licensed under the [MIT license](LICENSE.txt).

gemfiles/activesupport_7.2.gemfile

@@ -0,0 +1,5 @@
+# frozen_string_literal: true
+
+@activesupport_gem_requirement = "~> 7.2.0"
+
+eval_gemfile "../Gemfile"

lib/deprecation_toolkit.rb

@@ -44,7 +44,7 @@ def attach_subscriber
     def each_deprecator(&block)
       if defined?(Rails.application) && Rails.application.respond_to?(:deprecators)
         Rails.application.deprecators.each(&block)
-      else
+      elsif ActiveSupport::Deprecation.respond_to?(:behavior)
         block.call(ActiveSupport::Deprecation)
       end
     end

test/deprecation_toolkit/behaviors/raise_test.rb

@@ -13,6 +13,8 @@ class RaiseTest < ActiveSupport::TestCase
       end
 
       teardown do
+        # ensure we don't get warnings for missing assertions
+        pass # we have assertions in trigger_deprecation_toolkit_behavior
         Configuration.behavior = @previous_configuration
       end
 

test/minitest/deprecation_toolkit_plugin_test.rb

@@ -64,6 +64,16 @@ def deprecators
       end
     end
 
+    if ActiveSupport.gem_version >= Gem::Version.new("7.2.0")
+      test ".plugin_deprecation_toolkit_init doesn't try to set behavior on ActiveSupport::Deprecation if Rails isn't defined" do
+        stub_const(Object, :Rails, Object.new) do
+          assert_nothing_raised do
+            Minitest.plugin_deprecation_toolkit_init({})
+          end
+        end
+      end
+    end
+
     test ".plugin_deprecation_toolkit_init add `notify` behavior to the deprecations behavior list with Rails.application.deprecators" do
       behavior = ActiveSupport::Deprecation::DEFAULT_BEHAVIORS[:notify]