-
Notifications
You must be signed in to change notification settings - Fork 288
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): upgrade eslint to v9 #2716
base: main
Are you sure you want to change the base?
Conversation
Oxygen deployed a preview of your
Learn more about Hydrogen's GitHub integration. |
packages/hydrogen-react/src/analytics-schema-custom-storefront-customer-tracking.ts
Outdated
Show resolved
Hide resolved
We detected some changes in |
/* eslint-disable eslint-comments/disable-enable-pair */ | ||
/* eslint-disable eslint-comments/no-unlimited-disable */ | ||
/* eslint-disable */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is generated automatically. Deleting it here doesn't do anything since a npm run dev
would bring this back. We should ignore eslint on this file.
WHY are these changes introduced?
Fixes #191
WHAT is this pull request doing?
This PR:
templates/skeleton
lint-staged
script to run on the changed filesThe relevant files in the PR are:
I tried to find the best subset of rules so that we will be able to have even minimal linting over our codebase, but at the same time not to flood many warnings over packages that weren't linted until now. If in the future we will want to add/enable a new rule, we can do it and fix its errors.
HOW to test your changes?
npm i && npm run lint
from the root foldernpm i && npm run lint
from thetemplates/skeleton
folderChecklist