-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add GitHub providers #76
Conversation
…d old file. Updated index exports accordingly.
…pdating existing providers. Corrected typos in descriptions and improved source code retrieval logic to exclude test files. This update integrates test file handling into the GitHub plugin ecosystem.
…umentation files, and releases. Updated existing plugins to integrate these providers, improving the overall functionality and data retrieval capabilities of the GitHub integration.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added a few comments but other than that looks amazing! Great work :)
…ing files. This change simplifies the code by removing repetitive logic across multiple providers (documentation, releases, source code, test files, and workflow files) and enhances error handling with centralized logging. The GitHubService has also been updated to improve error logging consistency.
Awesome let me have a look rn :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - feel free to merge once it is tested and works as expected :) Great work!!
…tion in githubProviderUtil.ts. This change enhances flexibility by allowing the function to operate without requiring a specific path formatting function, streamlining the code for better usability.
@monilpat below the agent results that triggers all 5 providers:
|
Relates to:
GitHub Plugin Enhancement
Risks
Low - Changes are contained within the GitHub plugin package and don't affect core functionality.
Background
What does this PR do?
This PR enhances the GitHub plugin functionality by:
What kind of change is this?
Features (non-breaking change which adds functionality)
Improvements (misc. changes to existing features)
Documentation changes needed?
My changes require a change to the project documentation to reflect new GitHub plugin capabilities.
Testing
Where should a reviewer start?
packages/plugin-github/src/services/github.ts
to understand the core service changesDetailed testing steps
Deploy Notes
No special deployment steps required. Standard package deployment process applies.