Weldbot #1703
Merged
Weldbot #1703
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timfa2112
requested review from
DEATHB4DEFEAT,
sleepyyapril and
Remuchi
as code owners
github-actions
bot
added
Status: Needs Review
Remuchi
previously requested changes
Feb 2, 2025
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyWeldableOperator.cs
Outdated
Show resolved
Hide resolved
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyWeldableOperator.cs
Outdated
Show resolved
Hide resolved
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyWeldableOperator.cs
Outdated
Show resolved
Hide resolved
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyWeldableOperator.cs
Outdated
Show resolved
Hide resolved
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyWeldableOperator.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Remuchi <72476615+Remuchi@users.noreply.github.com> Signed-off-by: Timfa <timfalken@hotmail.com>
Co-authored-by: Remuchi <72476615+Remuchi@users.noreply.github.com> Signed-off-by: Timfa <timfalken@hotmail.com>
OldDanceJacket
approved these changes
Feb 5, 2025
sleepyyapril
requested changes
Feb 7, 2025
Comment on lines
50
to
54
| if (!blackboard.TryGetValue<float>(RangeKey, out var range, _entManager)) | ||
| return (false, null); | ||
|
|
||
| if (!_entManager.TryGetComponent<WeldbotComponent>(owner, out var weldbot)) | ||
| return (false, null); |
There was a problem hiding this comment.
Combined in 23a809c
Comment on lines
66
to
71
| if (!_entManager.TryGetComponent<TagComponent>(target, out var tagComponent) || !_tagSystem.HasTag(tagComponent, tagPrototype)) | ||
| continue; | ||
|
|
||
| // Only go towards a target if the bot can actually help them or if the weldbot is emagged | ||
| if (!emagged && damage.DamagePerGroup["Brute"].Value == 0) | ||
| continue; |
There was a problem hiding this comment.
Combined in 23a809c
Content.Server/NPC/HTN/PrimitiveTasks/Operators/Specific/PickNearbyWeldableOperator.cs
Show resolved
Hide resolved
Comment on lines
62
to
72
| if (!_entMan.TryGetComponent<TagComponent>(target, out var tagComponent) || !_tagSystem.HasTag(tagComponent, tagPrototype)) | ||
| return HTNOperatorStatus.Failed; | ||
|
|
||
| if (!_entMan.TryGetComponent<WeldbotComponent>(owner, out var botComp)) | ||
| return HTNOperatorStatus.Failed; | ||
|
|
||
| if (!_entMan.TryGetComponent<DamageableComponent>(target, out var damage)) | ||
| return HTNOperatorStatus.Failed; | ||
|
|
||
| if (!_interaction.InRangeUnobstructed(owner, target)) | ||
| return HTNOperatorStatus.Failed; |
There was a problem hiding this comment.
Combined in 23a809c
sleepyyapril
approved these changes
Feb 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The Weldbot is a medibot for IPC's, Borgs and other Silicon bots. It'll behave pretty much as a medibot would, except it welds.
Upon destruction, it will spill fuel on the ground. Nasty stuff.
Media
Note: The weldbot was slow in this video, and healed only 5 units of damage. It will heal 50 now, but I don't have an up-to-date video.
https://github.com/user-attachments/assets/11c2343b-3e7e-4536-8238-4ee28d51c045
Changelog
🆑 Timfa