Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

International Space Station Update - New Accent Traits #1712

Merged
merged 4 commits into from
Feb 4, 2025

Conversation

Peptide90
Copy link
Contributor

Ports Russian and German languages from Wizden and adds traits for them.

Also adds traits for Italian, French and Spanish since they already exist.

Not tested because the game didn't want to build locally.

Changelog

🆑

  • add: Added traits for accents: Russian, German, French, Italian and Spanish

@github-actions github-actions bot added Status: Needs Review Someone please review this Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files labels Feb 3, 2025
@Remuchi
Copy link
Contributor

Remuchi commented Feb 3, 2025

I hate that we're bringing the "real-world" accents and languages in the game so I'll pass on it. I'd really prefer we have as little things reminding of the real world as possible. It's all about fiction.

@Peptide90
Copy link
Contributor Author

Peptide90 commented Feb 3, 2025

I hate that we're bringing the "real-world" accents and languages in the game so I'll pass on it. I'd really prefer we have as little things reminding of the real world as possible. It's all about fiction.

Although I agree that this is the far future and all that, the accents are already in as a gimmick and Wizden already added one as a trait. Suppose its not unrealistic if there's the odd crew member who still preserved an accent.

I also don't really care much if this gets accepted or not. Players were requesting German and Russian on DS14 though.

Signed-off-by: Peptide90 <78795277+Peptide90@users.noreply.github.com>
@stellar-novas
Copy link
Contributor

stellar-novas commented Feb 3, 2025

I think having mechanical languages and accent languages together feels weird.

I'd be fine if these were behind a default disabled cvar though.

@sleepyyapril
Copy link
Contributor

we have irish and such, precedent already exists

can be changed in future pr, for now i merge because yall are silly

@sleepyyapril sleepyyapril merged commit 91eb7bf into Simple-Station:master Feb 4, 2025
10 of 11 checks passed
SimpleStation14 added a commit that referenced this pull request Feb 4, 2025
@sleepyyapril
Copy link
Contributor

we have irish and such, precedent already exists

can be changed in future pr, for now i merge because yall are silly

if you dont want these, fix the others too in your own pr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Changes: C# Changes any cs files Changes: Localization Changes any ftl files Changes: YML Changes any yml files Status: Needs Review Someone please review this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants