-
-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updating rift constants for new Skyblock update #2325
base: development
Are you sure you want to change the base?
Updating rift constants for new Skyblock update #2325
Conversation
No it was a bug, it was fixed in https://github.com/SkyCryptWebsite/SkyCryptv2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm all but ID
src/constants/rift.js
Outdated
@@ -68,8 +72,14 @@ export const RIFT_TIMECHARMS = [ | |||
id: 152, | |||
damage: 0, | |||
}, | |||
{ | |||
name: "Celestial Timecharm", | |||
type: "celestial", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lgtm, @Shiiyu can u merge this
Hypixel Skyblock 0.21 was recently released, and with it came updates to the Rift.
Warning: Check the Hypixel API for compatibility with the
celestial
id of the timecharmNote: First-time contributor; I am familiar with neither this project nor the Hypixel API very well.
Changed:
Question/Possible Issue (Unchanged):
Currently, The Prince eye currently has a texture id of [f26bde45049c7b7d34605d806a06829b6f955b856a5991fd33e7eabce44c0834] (a discolored, dark eye) rather than the common eye texture [17db1923d03c4ef4e9f6e872c5a6ad2578b1aff2b281fbc3ffa7466c825fb9] shared between the other Pohrtal eyes. As far as I know, The Prince is not textured this way after unlocking in-game, and the discolored eye texture is only displayed in-game before eyes have been unlocked, while SkyCrypt doesn't display anything before it has been unlocked. Is the different texture intentional?
src/constants/rift.js: