fix: Fix dispatch event checkout #3407
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Integration tests success for 814e4e22ae230c8ccd708b2bf4ef9c331c30818b |
This reverts commit dc0d872.
|
Integration tests cancelled for e5c5dfb40a46140cee089f89f03d71c3cfddb723 |
|
Integration tests failure for 3b5ce99f48c9045899547b899e7c00b448e1ccec |
sfc-gh-asawicki
requested changes
Feb 24, 2025
| if: (github.event_name == 'repository_dispatch') | ||
| uses: actions/checkout@v3 | ||
| with: | ||
| repository: ${{ github.event.client_payload.pull_request.head.repo.full_name }} |
There was a problem hiding this comment.
do we need to specify the repository name? Isn't it the default in this action?
There was a problem hiding this comment.
Should be fine (?) Default: ${{ github.repository }} not sure what is the difference between the two. Maybe there's some kind of additional data that can be passed to the repository field that would make it able to checkout on the fork (?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Test Plan
Dispatch events utilize pipelines from the default branch, and custom dispatch events cannot be run before merge—see https://github.com/orgs/community/discussions/24657?sort=top. This is why this change was not tested in this repository, as the changes already need to be present on the default branch.
Instead, I tested it on my personal repository with a simplified setup, but preserving the logic. I confirmed that for dispatch events, the checkout was done to the default origin branch, and after these changes, the checkout is done on the correct sha in the forked branch.
References
#3400 (comment)
TODO
Check the dispatch after it's merged to the default branch.