-
Notifications
You must be signed in to change notification settings - Fork 430
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: fix failing tests #3428
base: dev
Are you sure you want to change the base?
chore: fix failing tests #3428
Conversation
Integration tests failure for a6d81cb483f157a50ce0ce7d66bdebdfa6260cd8 |
Integration tests failure for 2135df96f0212cd49a4de5af3fc60e9166cb4425 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.
Integration tests failure for 422ba5ab328aaeaa208ee65cdfed6bb2707ad5cd |
pkg/resources/oauth_integration_for_partner_applications_acceptance_test.go
Show resolved
Hide resolved
@@ -9,3 +10,8 @@ func (a *AccountModel) WithAdminUserTypeEnum(adminUserType sdk.UserType) *Accoun | |||
a.AdminUserType = tfconfig.StringVariable(string(adminUserType)) | |||
return a | |||
} | |||
|
|||
func (a *AccountModel) WithAdminRsaPublicKeyMultiline(adminRsaPublicKey string) *AccountModel { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
it can be generated already, I will update the readme
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added to the list of multiline string arguments
pkg/resources/oauth_integration_for_partner_applications_acceptance_test.go
Show resolved
Hide resolved
pkg/resources/oauth_integration_for_partner_applications_acceptance_test.go
Show resolved
Hide resolved
Integration tests failure for cfa09042a9dd39c31f0a6482139df7623e7d3133 |
Integration tests failure for ecde2e6f48c5f8f4464a893f8879b9bc95aa5041 |
Integration tests failure for a1031f851671d492d4f27e125d52c6f0e555c62c |
Integration tests failure for 95283e93297d3a4e2a8add4092ebe8b134b81ae6 |
Integration tests failure for be290c3a23fe0fcfeb5e6ddc3bc0a4ebc6c4b173 |
Changes
Some of the tests may fail after adjusting network policies due to their connection with account parameters. This PR was made to check which ones fail after the adjustment and fix them.
Update: No tests regarding network policy failed after the change, but still some of them did fail and I adjusted them in this pr.
"
instead of heredoc)