Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix linting errors #32

Merged
merged 17 commits into from
Feb 22, 2024
Merged
Show file tree
Hide file tree
Changes from 14 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,13 +1,13 @@
module.exports = {
root: true,
env: {node: true, es2020: true},
env: {node: true, es2020: true, jest: true},
extends: [
'eslint:recommended'
],
ignorePatterns: ['dist', '.eslintrc.cjs', 'tests'],
parserOptions: {ecmaVersion: 'latest', sourceType: 'module'},
parser: '@typescript-eslint/parser',
plugins: ['jsdoc'],
plugins: ['jsdoc', 'jest'],
rules: {
'prefer-const': ['error', {
'destructuring': 'any',
Expand Down Expand Up @@ -50,7 +50,7 @@ module.exports = {
// 'jsdoc/require-example': 1,
// 'jsdoc/require-file-overview': 1,
'jsdoc/require-hyphen-before-param-description': 1,
'jsdoc/require-jsdoc': 1, // Recommended
'jsdoc/require-jsdoc': [1, { contexts: ['ClassDeclaration', 'ClassProperty', 'FunctionDeclaration', 'MethodDefinition'] }],
'jsdoc/require-param': 1, // Recommended
'jsdoc/require-param-description': 1, // Recommended
'jsdoc/require-param-name': 1, // Recommended
Expand Down
6 changes: 4 additions & 2 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ npm-debug.log*
yarn-debug.log*
yarn-error.log*
lerna-debug.log*

.idea/
# Diagnostic reports (https://nodejs.org/api/report.html)
report.[0-9]*.[0-9]*.[0-9]*.[0-9]*.json

Expand Down Expand Up @@ -108,4 +108,6 @@ src/config/authentication_map.ts
src/utils/rsp.ts
src/utils/DecentralizedFileStreamer.ts
src/utils/UpdateLDES.ts
aggregation-data
aggregation-data
logs/
scratch/
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ We employ [Type Indexes](https://solid.github.io/type-indexes/) to store the loc
npm run start-solid-server
```
The command will start a Solid Server on the port 3000 with a Solid Pod named `aggregation_pod` which can be accessed at `http://localhost:3000/aggregation_pod/`. The aggregation results are stored in the aggregator's Solid Pod in form of the LDES stream using the [LDES in LDP](https://woutslabbinck.github.io/LDESinLDP/) specification.

- Create a folder and a file named `logs/aggregation.log` in the root directory of the project. The logs of the Solid Stream Aggregator is stored in this file.
pheyvaer marked this conversation as resolved.
Show resolved Hide resolved
- Now, start the Solid Stream Aggregator with the command
```bash
npm run start aggregation
Expand Down Expand Up @@ -60,4 +60,4 @@ This code is copyrighted by [Ghent University - imec](https://www.ugent.be/ea/id

## Contact

For any questions, please contact [Kush](mailto:kushagrasingh.bisen@ugent.be) or create an issue in the repository [here])(https://github.com/SolidLabResearch/solid-stream-aggregator/issues) .
For any questions, please contact [Kush](mailto:kushagrasingh.bisen@ugent.be) or create an issue in the repository [here](https://github.com/SolidLabResearch/solid-stream-aggregator/issues) .
6 changes: 6 additions & 0 deletions esdoc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,6 @@
{
"source": "./src",
"destination": "./docs",
"plugins": [{"name": "esdoc-standard-plugin"}]
}

3 changes: 0 additions & 3 deletions logs/aggregation.log
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Logs don't belong in a repo, unless there is very specific reason why they should be.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will add them to .gitignore

This file was deleted.

46 changes: 0 additions & 46 deletions logs/module_processing_time.csv

This file was deleted.

75 changes: 0 additions & 75 deletions logs/process.ipynb

This file was deleted.

40 changes: 0 additions & 40 deletions logs/processCSV.ts

This file was deleted.

74 changes: 0 additions & 74 deletions logs/processLog.ts

This file was deleted.

45 changes: 0 additions & 45 deletions module_processing_time.csv

This file was deleted.

Loading
Loading